Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[StyleCop] Fix all warnings in Bot.Schema #1502

Merged
merged 1 commit into from
Mar 26, 2019
Merged

[StyleCop] Fix all warnings in Bot.Schema #1502

merged 1 commit into from
Mar 26, 2019

Conversation

ceciliaavila
Copy link
Collaborator

  • Reorder methods
  • Add trailing comma in multi-line initializers
  • Remove empty blank lines
  • Remove trailing white spaces

@ceciliaavila ceciliaavila mentioned this pull request Mar 18, 2019
Closed
@coveralls
Copy link
Collaborator

coveralls commented Mar 20, 2019 •
edited

Pull Request Test Coverage Report for Build 52214

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 75.544%
Totals Coverage Status
Change from base Build 52177: 0.0%
Covered Lines: 4306
Relevant Lines: 5700
💛 - Coveralls

@ParadoxARG ParadoxARG marked this pull request as ready for review March 20, 2019 14:43
munozemilio
munozemilio previously requested changes Mar 25, 2019
View reviewed changes
Copy link
Member

@munozemilio munozemilio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just added a comment on keeping the changes consistent.

Thanks,
Emilio

@Bill7zz @JuanAr
Fix StyleCop Warnings in Bot.Schema
609e759 
- Reorder methods
- Add trailing comma in multi-line initializers
- Remove empty blank lines
- Remove trailing white spaces
@cleemullins cleemullins dismissed munozemilio’s stale review March 26, 2019 23:13

Change has been applied.

@cleemullins cleemullins merged commit f6d0d69 into master Mar 26, 2019
@cleemullins cleemullins deleted the fix/stylecop/bot-schema branch March 26, 2019 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JuanAr JuanAr JuanAr left review comments

@cleemullins cleemullins cleemullins approved these changes

@munozemilio munozemilio munozemilio left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@ceciliaavila @coveralls @JuanAr @cleemullins @munozemilio @Bill7zz