Allow the user to specify a tenant when acquiring a token to talk to … #1576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 52808
💛 - Coveralls |
cleemullins
suggested changes
Mar 29, 2019
libraries/Microsoft.Bot.Connector/Authentication/MicrosoftAppCredentials.cs
Outdated
Show resolved
Hide resolved
libraries/Microsoft.Bot.Connector/Authentication/MicrosoftAppCredentials.cs
Outdated
Show resolved
Hide resolved
libraries/Microsoft.Bot.Connector/Authentication/MicrosoftAppCredentials.cs
Show resolved
Hide resolved
libraries/Microsoft.Bot.Connector/Authentication/MicrosoftAppCredentials.cs
Outdated
Show resolved
Hide resolved
| [Fact] | ||
| public async Task TokenTests_GetCredentialsFromTenantWorks() | ||
| { | ||
| MicrosoftAppCredentials credentials = new MicrosoftAppCredentials("645cd89f-a83e-4af9-abb5-a454e917cbc4", "jvoMWRBA67:zjgePZ359_-_", "microsoft.com", null); |
There was a problem hiding this comment.
2 things here:
-
We cannot put magic keys / constants in code. If we did this, the keys needs to be stored as encrypted variables in Azure Devops and passed into the build via ENV variables. (This is a super-common pattern).
-
We cannot put actual "Service" tests here. These are unit tests, and cannot hit actual services.
There was a problem hiding this comment.
this is how tests are written in this file. I'm copying the existing pattern.
There was a problem hiding this comment.
Alright, I'll clean this up seperatly.
cleemullins
approved these changes
Apr 2, 2019
6 tasks
This was referenced Apr 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…the BF connectors