-
Notifications
You must be signed in to change notification settings - Fork 478
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Cosmos DB tests #1616
Fix Cosmos DB tests #1616
Conversation
Pull Request Test Coverage Report for Build 52984
💛 - Coveralls |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So...
Based on the tests, it's clear the behavior of the library has changed. The old behavior - which is more permissive and easier to deal with - seems the preferred behavior.
Rather than changing the tests to match the new behavior, can we update the code to make the old tests pass?
My thinking is that the expected behavior is that if I write "nothing" it should just work and not make me deal with Exeptions.
Same goes for "Read null", it should just return an empty set.
... both cases make my code easier to write and deal with.
Hi @cleemullins , that means revert @johnataylor commit, is that OK? |
Spoke with @johnataylor . He convinced me. Merging. |
* Fix Namespace issue in Microsoft.Bot.Connector.Tests * Fix Cosmos DB tests (#1616) * Removed unused libraries * Moving classes to correct namespace
WriteAsync and ReadAsync CosmosDbStorage.cs implementations throw ArgumentNullException when passing null as object to store or keys to look for.
Test were broken since both were asserting a different behavior.