Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[nodejs parity] Allow LUIS endpoint to be null or empty #1626

Merged
merged 1 commit into from
Apr 7, 2019

Conversation

daveta
Copy link
Contributor

@daveta daveta commented Apr 4, 2019

Fixes #1387

Enable empty endpoint (just like nodejs)!

@daveta daveta added 4.4 April 15, 2019 Release Parity with JS Required labels Apr 4, 2019
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 53309

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.004%) to 76.126%

Totals Coverage Status
Change from base Build 53133: 0.004%
Covered Lines: 4362
Relevant Lines: 5730

💛 - Coveralls

@cleemullins
Copy link
Contributor

No issues found in Microsoft.Bot.Builder.dll
No issues found in Microsoft.Bot.Builder.AI.Luis.dll
No issues found in Microsoft.Bot.Builder.AI.QnA.dll
No issues found in Microsoft.Bot.Builder.ApplicationInsights.dll
No issues found in Microsoft.Bot.Builder.Azure.dll
No issues found in Microsoft.Bot.Builder.Dialogs.dll
No issues found in Microsoft.Bot.Builder.TemplateManager.dll
No issues found in Microsoft.Bot.Configuration.dll
No issues found in Microsoft.Bot.Connector.dll
No issues found in Microsoft.Bot.Schema.dll

@cleemullins cleemullins merged commit 6c83e75 into master Apr 7, 2019
@cleemullins cleemullins deleted the daveta-luis-endpoint branch April 7, 2019 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4.4 April 15, 2019 Release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants