Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Made BotState CRUD operations virtual so they can be mocked for testing. #1764

Merged
merged 1 commit into from
Apr 23, 2019
Merged

Made BotState CRUD operations virtual so they can be mocked for testing. #1764

merged 1 commit into from
Apr 23, 2019

Conversation

gabog
Copy link
Contributor

@gabog gabog commented Apr 23, 2019

This commit makes LoadAsync, SaveChangesAsync, ClearStateAsync and ClearStateAsync virtual so they can be mocked in unit tests.

@gabog gabog added the 4.4 April 15, 2019 Release label Apr 23, 2019
@cleemullins
Copy link
Contributor 

No issues found in Microsoft.Bot.Builder.dll
No issues found in Microsoft.Bot.Builder.AI.Luis.dll
No issues found in Microsoft.Bot.Builder.AI.QnA.dll
No issues found in Microsoft.Bot.Builder.ApplicationInsights.dll
No issues found in Microsoft.Bot.Builder.Azure.dll
No issues found in Microsoft.Bot.Builder.Dialogs.dll
No issues found in Microsoft.Bot.Builder.TemplateManager.dll
No issues found in Microsoft.Bot.Configuration.dll
No issues found in Microsoft.Bot.Connector.dll
No issues found in Microsoft.Bot.Schema.dll

@cleemullins cleemullins merged commit a4800bd into master Apr 23, 2019
@cleemullins cleemullins deleted the gabog/MakeSaveStateVirtual branch April 23, 2019 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cleemullins cleemullins cleemullins approved these changes

@johnataylor johnataylor Awaiting requested review from johnataylor

Assignees
No one assigned
Labels
4.4 April 15, 2019 Release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gabog @cleemullins