Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Expression]Add string interpolation #2968

Merged
merged 31 commits into from
Feb 8, 2020
Merged

[Expression]Add string interpolation #2968

merged 31 commits into from
Feb 8, 2020

Conversation

Danieladu
Copy link
Collaborator

@Danieladu Danieladu commented Nov 14, 2019 •
edited

fix: #2785

@microsoft microsoft deleted a comment from fuselabs Nov 20, 2019
@microsoft microsoft deleted a comment from fuselabs Nov 20, 2019
@Danieladu Danieladu added the WIP label Nov 20, 2019
@microsoft microsoft deleted a comment from fuselabs Nov 29, 2019
@microsoft microsoft deleted a comment from fuselabs Nov 29, 2019
@microsoft microsoft deleted a comment from fuselabs Nov 29, 2019
@microsoft microsoft deleted a comment from fuselabs Nov 29, 2019
@microsoft microsoft deleted a comment from fuselabs Nov 29, 2019
@microsoft microsoft deleted a comment from coveralls Nov 29, 2019
@microsoft microsoft deleted a comment from fuselabs Dec 20, 2019
@microsoft microsoft deleted a comment from fuselabs Dec 20, 2019
@johnataylor
Copy link
Member

This has sat in a DRAFT state for months. Please use working branches unless you are actively seeking feedback.

I'm closing this today. If this work is ready for review, please feel free to reopen.

@Danieladu Danieladu reopened this Feb 6, 2020
@Danieladu Danieladu marked this pull request as ready for review February 6, 2020 03:40
@boydc2014 boydc2014 removed the WIP label Feb 6, 2020
@microsoft microsoft deleted a comment from fuselabs Feb 6, 2020
@microsoft microsoft deleted a comment from fuselabs Feb 6, 2020
@microsoft microsoft deleted a comment from fuselabs Feb 6, 2020
@microsoft microsoft deleted a comment from fuselabs Feb 6, 2020
@microsoft microsoft deleted a comment from fuselabs Feb 6, 2020
@microsoft microsoft deleted a comment from fuselabs Feb 6, 2020
@microsoft microsoft deleted a comment from fuselabs Feb 6, 2020
@microsoft microsoft deleted a comment from fuselabs Feb 6, 2020
@microsoft microsoft deleted a comment from fuselabs Feb 7, 2020
tomlm
tomlm approved these changes Feb 8, 2020
View reviewed changes
Copy link
Contributor

@tomlm tomlm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@fuselabs
Copy link
Collaborator

fuselabs commented Feb 8, 2020

✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.Luis.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.QnA.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.ApplicationInsights.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Azure.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Dialogs.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Integration.ApplicationInsights.Core.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Integration.AspNet.Core.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.TemplateManager.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Testing.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Configuration.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Connector.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Schema.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Streaming.dll compared against version 4.6.3

@tomlm tomlm merged commit 3348bc1 into master Feb 8, 2020
@tomlm tomlm deleted the hond/string_interpolation branch February 8, 2020 17:20
This was referenced Feb 8, 2020
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boydc2014 boydc2014 boydc2014 approved these changes

@tomlm tomlm tomlm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[LG] [DCR] String interpolation for functions, LG
5 participants
@Danieladu @johnataylor @fuselabs @boydc2014 @tomlm