Cleanup and consolidate TypeFactory/loading/configuration/ExpressionEngine/registration etc. #3350

tomlm · 2020-02-07T02:25:51Z

Add HostContext for global assets like IConfiguration
Add ComponentRegistration discovery
Break interfaces apart for components registrations
Added Expression.Parse with global function table
Removed IExpressionEngineFactory
drop SetStateConfiguration
Merge TypeFactory and DeclarativeTypeLoader with ResourceExplorer
Added DialogManager.TurnState to allow dialog manager to set initial TurnState for registering * components like LanguageGenerator and ResourceExplorer
Dropped adapter .Use methods and moved them to DialogManager * (UseResourceExplorer/UseLanguageGeneration etc)
Drop Resource Plugins
Merge RefResolver into ResourceExplorer
rename TypeRegistration to DeclarativeTypeRegistration
Add Configuration.UseLuisSettings()

Add ComponentRegistration discovery Break interfaces apart for components registrations Added Expression.Parse with global function table Removed IExpressionEngineFactory drop SetStateConfiguration Merge TypeFactory and DeclarativeTypeLoader with ResourceExplorer Added DialogManager.TurnState to allow dialog manager to set initial TurnState for registering components like LanguageGenerator and ResourceExplorer Dropped adapter .Use methods and moved them to DialogManager (UseResourceExplorer/UseLanguageGeneration etc) Drop Resource Plugins Merge RefResolver into ResourceExplorer rename TypeRegistration to KindRegistration Add Configuration.UseLuisSettings()

coveralls · 2020-02-07T02:41:33Z

Pull Request Test Coverage Report for Build 104731

0 of 0 changed or added relevant lines in 0 files are covered.
1285 unchanged lines in 152 files lost coverage.
Overall coverage decreased (-1.4%) to 78.168%

Files with Coverage Reduction	New Missed Lines	%
/libraries/Adapters/Microsoft.Bot.Builder.Adapters.Facebook/FacebookAdapterOptions.cs	1	86.67%
/libraries/integration/Microsoft.Bot.Builder.Integration.ApplicationInsights.Core/ApplicationBuilderExtensions.cs	1	71.43%
/libraries/Microsoft.Bot.Builder.AI.LUIS/LuisApplication.cs	1	96.36%
/libraries/Microsoft.Bot.Builder.AI.LUIS/V3/LuisApplication.cs	1	96.43%
/libraries/Microsoft.Bot.Builder.AI.LUIS/V3/LuisUtil.cs	1	96.35%
/libraries/Microsoft.Bot.Builder/BotStateSet.cs	1	85.0%
/libraries/Microsoft.Bot.Builder.Dialogs/Debugging/DebugSupport.cs	1	75.0%
/libraries/Microsoft.Bot.Builder.Dialogs/Debugging/SourceRange.cs	1	46.15%
/libraries/Microsoft.Bot.Builder.Dialogs/Prompts/PromptCultureModels.cs	1	97.53%
/libraries/Microsoft.Bot.Builder.Dialogs/Prompts/PromptValidatorContext.cs	1	82.35%

Totals
Change from base Build 104413:	-1.4%
Covered Lines:	21279
Relevant Lines:	27222

💛 - Coveralls

fuselabs · 2020-02-07T02:43:26Z

✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.Luis.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.QnA.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.ApplicationInsights.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Azure.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Dialogs.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Integration.ApplicationInsights.Core.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Integration.AspNet.Core.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.TemplateManager.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Testing.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Configuration.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Connector.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Schema.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Streaming.dll compared against version 4.6.3

fuselabs · 2020-02-07T18:11:46Z

✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.Luis.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.QnA.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.ApplicationInsights.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Azure.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Dialogs.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Integration.ApplicationInsights.Core.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Integration.AspNet.Core.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.TemplateManager.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Testing.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Configuration.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Connector.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Schema.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Streaming.dll compared against version 4.6.3

chrimc62 · 2020-02-07T18:27:10Z

/// </remarks>

Did you want to fill this in or remove it? #Resolved

Refers to: libraries/Microsoft.Bot.Builder/TurnContextStateCollection.cs:14 in ad51e27. [](commit_id = ad51e27, deletion_comment = False)

chrimc62 · 2020-02-07T18:27:42Z

public class TurnContextStateCollection : Dictionary<string, object>, IDisposable

I'm a little confused--you HostContext class talks about being the TurnContext--so how does that relate to this? #Resolved

Refers to: libraries/Microsoft.Bot.Builder/TurnContextStateCollection.cs:15 in ad51e27. [](commit_id = ad51e27, deletion_comment = False)

libraries/Microsoft.Bot.Builder.Dialogs.Adaptive/AdaptiveComponentRegistration.cs

libraries/Microsoft.Bot.Builder.Dialogs.Adaptive/IComponentMemoryScopes.cs

libraries/Microsoft.Bot.Builder.Dialogs.Adaptive/IComponentPathResolvers.cs

libraries/Microsoft.Bot.Builder.Dialogs.Adaptive/JObjectConverter.cs

libraries/Microsoft.Bot.Builder.Dialogs.Adaptive/LanguageGenerationComponentRegistration.cs

libraries/Microsoft.Bot.Builder.Dialogs.Adaptive/LanguageGeneratorConverter.cs

libraries/Microsoft.Bot.Builder.Dialogs.Adaptive/LGExtensions.cs

libraries/Microsoft.Bot.Builder.Dialogs.Adaptive/LUIS/LuisComponentRegistration.cs

...soft.Bot.Builder.Dialogs.Adaptive/Memory/Expressions/Converters/DialogExpressionConverter.cs

chrimc62 · 2020-02-07T18:51:17Z

/// <typeparam name="T">botState type.</typeparam>

Capital #Resolved

Refers to: libraries/Microsoft.Bot.Builder.Dialogs.Adaptive/Memory/Scopes/BotStateMemoryScope.cs:18 in ad51e27. [](commit_id = ad51e27, deletion_comment = False)

libraries/Microsoft.Bot.Builder.Dialogs.Adaptive/QnAMaker/QnAMakerComponentRegistration.cs

libraries/Microsoft.Bot.Builder.Dialogs.Adaptive/Selectors/MostSpecificSelector.cs

libraries/Microsoft.Bot.Builder.Dialogs.Adaptive/Testing/TestScript.cs

libraries/Microsoft.Bot.Builder.Dialogs.Adaptive/IComponentMemoryScopes.cs

libraries/Microsoft.Bot.Builder.Dialogs.Adaptive/IComponentPathResolvers.cs

libraries/Microsoft.Bot.Builder.Dialogs.Adaptive/Testing/MockLuis/MockLuisExtensions.cs

libraries/Microsoft.Bot.Builder.Dialogs.Declarative/ComponentRegistration.cs

libraries/Microsoft.Bot.Builder.Dialogs.Declarative/DeclarativeComponentRegistration.cs

libraries/Microsoft.Bot.Builder.Dialogs.Declarative/IComponentDeclarativeTypes.cs

libraries/Microsoft.Bot.Builder/HostContext.cs

libraries/Microsoft.Bot.Expressions/IComponentExpressionFunctions.cs

libraries/Microsoft.Bot.Expressions/TriggerTrees/TriggerTree.cs

libraries/Microsoft.Bot.Expressions.Properties/StringExpression.cs

tests/Microsoft.Bot.Builder.Dialogs.Adaptive.Profiling/Program.cs

tests/Microsoft.Bot.Builder.Dialogs.Adaptive.Tests/GeneratorTests.cs

tests/Microsoft.Bot.Builder.Dialogs.Declarative.Tests/JsonLoadTests.cs

tests/Microsoft.Bot.Builder.TestBot.Json/luis.settings.tomlm.westus.json

tests/Microsoft.Bot.Builder.TestBot.Json/Samples/GeneratedForm/luis/sandwich.en-us.lu

tests/Microsoft.Bot.Builder.TestBot.Json/Samples/GeneratedForm/luis/sandwich.en-us.lu.dialog

...Microsoft.Bot.Builder.TestBot.Json/Samples/ToDoLuisBot/luis.settings.development.westus.json

...ft.Bot.Builder.TestBot.Json/Samples/GeneratedForm/luis/luis.settings.development.westus.json

chrimc62

🕐

* comments * headers * fixed expression optional/ignore and added unit tets * restored jsonload * more comments

chrimc62 · 2020-02-07T23:13:29Z

libraries/Microsoft.Bot.Builder.Dialogs.Adaptive/ActivityTemplateConverter.cs

@@ -9,6 +9,9 @@

 namespace Microsoft.Bot.Builder.Dialogs.Adaptive
 {
+    /// <summary>
+    /// JsonConverter to load ITemplate&lt;Activity&gt;.


ITemplate<Activity&gt [](start = 30, length = 24)

Probably better to do a <see cref

chrimc62 · 2020-02-07T23:15:00Z

...soft.Bot.Builder.Dialogs.Adaptive/Memory/Expressions/Converters/DialogExpressionConverter.cs

+        /// <summary>
+        /// Initializes a new instance of the <see cref="DialogExpressionConverter"/> class.
+        /// </summary>
+        /// <param name="resourceExplorer">resource explorer to use for resolving references.</param>


resource [](start = 43, length = 8)

Capital.

tests/Microsoft.Bot.Expressions.Tests/BadExpressionTests.cs

tests/Microsoft.Bot.Expressions.Tests/ExpressionEngineTests.cs

chrimc62

fuselabs · 2020-02-08T00:16:01Z

✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.Luis.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.QnA.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.ApplicationInsights.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Azure.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Dialogs.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Integration.ApplicationInsights.Core.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Integration.AspNet.Core.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.TemplateManager.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Testing.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Configuration.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Connector.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Schema.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Streaming.dll compared against version 4.6.3

Tom Laird-McConnell added 4 commits February 6, 2020 15:19

add updateluis

5949c02

update coments

77c44b2

Merge branch 'master' into tomlm/typeloading

db95890

tomlm added adaptive R8 Release 8 - March 16th, 2020 labels Feb 7, 2020

tomlm requested review from Stevenic, chrimc62 and carlosscastro February 7, 2020 02:25

Tom Laird-McConnell added 2 commits February 6, 2020 19:16

add IComponentExpressionFunction for custom functions

7fee01d

fix issue with netcore31

ad51e27

chrimc62 reviewed Feb 7, 2020

View reviewed changes

libraries/Microsoft.Bot.Builder.Dialogs.Adaptive/AdaptiveComponentRegistration.cs Show resolved Hide resolved

chrimc62 reviewed Feb 7, 2020

View reviewed changes

libraries/Microsoft.Bot.Builder.Dialogs.Adaptive/IComponentMemoryScopes.cs Show resolved Hide resolved

chrimc62 reviewed Feb 7, 2020

View reviewed changes

libraries/Microsoft.Bot.Builder.Dialogs.Adaptive/IComponentPathResolvers.cs Show resolved Hide resolved

chrimc62 reviewed Feb 7, 2020

View reviewed changes

libraries/Microsoft.Bot.Builder.Dialogs.Adaptive/JObjectConverter.cs Show resolved Hide resolved

chrimc62 reviewed Feb 7, 2020

View reviewed changes

libraries/Microsoft.Bot.Builder.Dialogs.Adaptive/LanguageGenerationComponentRegistration.cs Show resolved Hide resolved

chrimc62 reviewed Feb 7, 2020

View reviewed changes

libraries/Microsoft.Bot.Builder.Dialogs.Adaptive/LanguageGeneratorConverter.cs Show resolved Hide resolved

chrimc62 reviewed Feb 7, 2020

View reviewed changes

libraries/Microsoft.Bot.Builder.Dialogs.Adaptive/LGExtensions.cs Show resolved Hide resolved

chrimc62 reviewed Feb 7, 2020

View reviewed changes

libraries/Microsoft.Bot.Builder.Dialogs.Adaptive/LUIS/LuisComponentRegistration.cs Show resolved Hide resolved

chrimc62 reviewed Feb 7, 2020

View reviewed changes

...soft.Bot.Builder.Dialogs.Adaptive/Memory/Expressions/Converters/DialogExpressionConverter.cs Show resolved Hide resolved

chrimc62 reviewed Feb 7, 2020

View reviewed changes

libraries/Microsoft.Bot.Builder.Dialogs.Adaptive/QnAMaker/QnAMakerComponentRegistration.cs Show resolved Hide resolved

chrimc62 reviewed Feb 7, 2020

View reviewed changes

libraries/Microsoft.Bot.Builder.Dialogs.Adaptive/Selectors/MostSpecificSelector.cs Show resolved Hide resolved

chrimc62 reviewed Feb 7, 2020

View reviewed changes

libraries/Microsoft.Bot.Builder.Dialogs.Adaptive/Testing/TestScript.cs Show resolved Hide resolved

carlosscastro reviewed Feb 7, 2020

View reviewed changes

chrimc62 reviewed Feb 7, 2020

View reviewed changes

libraries/Microsoft.Bot.Expressions/IComponentExpressionFunctions.cs Show resolved Hide resolved

chrimc62 reviewed Feb 7, 2020

View reviewed changes

libraries/Microsoft.Bot.Expressions/TriggerTrees/TriggerTree.cs Show resolved Hide resolved

chrimc62 reviewed Feb 7, 2020

View reviewed changes

libraries/Microsoft.Bot.Expressions.Properties/StringExpression.cs Outdated Show resolved Hide resolved

chrimc62 reviewed Feb 7, 2020

View reviewed changes

tests/Microsoft.Bot.Builder.Dialogs.Adaptive.Profiling/Program.cs Outdated Show resolved Hide resolved

chrimc62 reviewed Feb 7, 2020

View reviewed changes

tests/Microsoft.Bot.Builder.Dialogs.Adaptive.Tests/GeneratorTests.cs Show resolved Hide resolved

chrimc62 reviewed Feb 7, 2020

View reviewed changes

tests/Microsoft.Bot.Builder.Dialogs.Declarative.Tests/JsonLoadTests.cs Outdated Show resolved Hide resolved

chrimc62 reviewed Feb 7, 2020

View reviewed changes

tests/Microsoft.Bot.Builder.TestBot.Json/luis.settings.tomlm.westus.json Show resolved Hide resolved

chrimc62 reviewed Feb 7, 2020

View reviewed changes

tests/Microsoft.Bot.Builder.TestBot.Json/Samples/GeneratedForm/luis/sandwich.en-us.lu Show resolved Hide resolved

chrimc62 reviewed Feb 7, 2020

View reviewed changes

tests/Microsoft.Bot.Builder.TestBot.Json/Samples/GeneratedForm/luis/sandwich.en-us.lu.dialog Show resolved Hide resolved

chrimc62 reviewed Feb 7, 2020

View reviewed changes

...Microsoft.Bot.Builder.TestBot.Json/Samples/ToDoLuisBot/luis.settings.development.westus.json Show resolved Hide resolved

chrimc62 reviewed Feb 7, 2020

View reviewed changes

...ft.Bot.Builder.TestBot.Json/Samples/GeneratedForm/luis/luis.settings.development.westus.json Show resolved Hide resolved

chrimc62 suggested changes Feb 7, 2020

View reviewed changes

Tom Laird-McConnell added 4 commits February 7, 2020 14:20

changes based on code review

952ffb9

* comments * headers * fixed expression optional/ignore and added unit tets * restored jsonload * more comments

make transcript tests run faster by reducing delay by 10x

5dc2e06

make typing tets faster

c846986

fix stylecop issue

76a550f

chrimc62 reviewed Feb 7, 2020

View reviewed changes

tests/Microsoft.Bot.Expressions.Tests/BadExpressionTests.cs Outdated Show resolved Hide resolved

chrimc62 reviewed Feb 7, 2020

View reviewed changes

tests/Microsoft.Bot.Expressions.Tests/ExpressionEngineTests.cs Outdated Show resolved Hide resolved

chrimc62 approved these changes Feb 7, 2020

View reviewed changes

Tom Laird-McConnell added 3 commits February 7, 2020 15:30

fix optional/ignore semantics

e7d2638

Fix comment.

a6dd05f

fix broken build caused by lack of a period in a comment. Yes. Really.

36f28ab

tomlm merged commit 6955e38 into master Feb 8, 2020

tomlm deleted the tomlm/typeloading branch February 8, 2020 00:19

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Cleanup and consolidate TypeFactory/loading/configuration/ExpressionEngine/registration etc. #3350

Cleanup and consolidate TypeFactory/loading/configuration/ExpressionEngine/registration etc. #3350

tomlm commented Feb 7, 2020 •

edited

coveralls commented Feb 7, 2020 •

edited

fuselabs commented Feb 7, 2020

fuselabs commented Feb 7, 2020

chrimc62 commented Feb 7, 2020 •

edited by tomlm

chrimc62 commented Feb 7, 2020 •

edited by tomlm

chrimc62 commented Feb 7, 2020 •

edited by tomlm

chrimc62 left a comment

chrimc62 Feb 7, 2020

chrimc62 Feb 7, 2020

chrimc62 left a comment

fuselabs commented Feb 8, 2020

Cleanup and consolidate TypeFactory/loading/configuration/ExpressionEngine/registration etc. #3350

Cleanup and consolidate TypeFactory/loading/configuration/ExpressionEngine/registration etc. #3350

Conversation

tomlm commented Feb 7, 2020 • edited

coveralls commented Feb 7, 2020 • edited

Pull Request Test Coverage Report for Build 104731

💛 - Coveralls

fuselabs commented Feb 7, 2020

fuselabs commented Feb 7, 2020

chrimc62 commented Feb 7, 2020 • edited by tomlm

chrimc62 commented Feb 7, 2020 • edited by tomlm

chrimc62 commented Feb 7, 2020 • edited by tomlm

chrimc62 left a comment

Choose a reason for hiding this comment

chrimc62 Feb 7, 2020

Choose a reason for hiding this comment

chrimc62 Feb 7, 2020

Choose a reason for hiding this comment

chrimc62 left a comment

Choose a reason for hiding this comment

fuselabs commented Feb 8, 2020

tomlm commented Feb 7, 2020 •

edited

coveralls commented Feb 7, 2020 •

edited

chrimc62 commented Feb 7, 2020 •

edited by tomlm

chrimc62 commented Feb 7, 2020 •

edited by tomlm

chrimc62 commented Feb 7, 2020 •

edited by tomlm