Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Samples to support anonymous Auth coming from the Emulator #69

Merged
merged 1 commit into from Feb 6, 2018

Conversation

cleemullins
Copy link
Contributor

The emulator DOES NOT send an authorization token when it's in anonymous mode. The code added to the samples yesterday was assuming it would, and REJECTING requests that had no auth header.

This behavior is incorrect for anonymous requests.

@cleemullins cleemullins added the bug Indicates an unexpected problem or an unintended behavior. label Feb 6, 2018
@cleemullins cleemullins added this to the 2/9 milestone Feb 6, 2018
@cleemullins cleemullins self-assigned this Feb 6, 2018
@cleemullins cleemullins merged commit 25b9a89 into master Feb 6, 2018
@cleemullins cleemullins deleted the CLM-EnableAnonymousAuthFromEmulatorInSamples branch February 6, 2018 21:28
Copy link
Contributor

@pcostantini pcostantini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The AppSettings from Alarmbot were committed with an AppID & Password
(nevermind! was fixed on later PR)

kant added a commit to kant/botbuilder-dotnet that referenced this pull request Sep 10, 2018
tomlm added a commit that referenced this pull request Sep 10, 2018
tomlm pushed a commit that referenced this pull request Nov 27, 2018
tomlm added a commit that referenced this pull request Nov 27, 2018
ShYuPe pushed a commit to ShYuPe/botbuilder-dotnet that referenced this pull request Aug 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Indicates an unexpected problem or an unintended behavior.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants