remove property name existance check from botstate

libraries/botbuilder-core/src/botState.ts

@@ -38,10 +38,6 @@ export interface CachedBotState {
  */
 export class BotState implements PropertyManager {
 
-    /**
-     * Collection of state property accessors added through [createProperty()](#createproperty).
-     */
-    public readonly properties: Map<string, StatePropertyAccessor> = new Map();
     private stateKey: symbol = Symbol('state');
 
     /**
@@ -58,10 +54,7 @@ export class BotState implements PropertyManager {
      * @param name Name of the property to add. Must be unique within the set.
      */
     public createProperty<T = any>(name: string): StatePropertyAccessor<T> {
-        if (this.properties.has(name)) { throw new Error(`BotState.createProperty(): a property named '${ name }' already exists.`); }
         const prop: BotStatePropertyAccessor<T> = new BotStatePropertyAccessor<T>(this, name);
-        this.properties.set(name, prop);
-
         return prop;
     }
 

libraries/botbuilder-core/tests/botState.test.js

@@ -122,19 +122,4 @@ describe(`BotState`, function () {
         assert(count !== undefined, `did not successfully create PropertyAccessor.`);
         done();
     });
-
-    it(`should not allow registering of PropertyAccessors with the same name`, function (done) {
-        const duplicateName = 'test';
-        let testA = botState.createProperty(duplicateName, 0);
-        try {
-            let testB = botState.createProperty(duplicateName, 0);
-        } catch (e) {
-            // Checking the error message because JavaScript does not have specific Error types like Python, e.g. ValueError.
-            // This message check verifies that the bot threw the correct error, and that not something else is breaking.
-            assert(e.message === `BotState.createProperty(): a property named '${duplicateName}' already exists.`, `another error was thrown: "${e.message}".`);
-            done();
-        }
-        throw new Error(`Should have raised a duplicate property name error.`);
-        done();
-    });
 });