Skip to content
This repository has been archived by the owner on Jun 28, 2023. It is now read-only.

MSBOT: Do not prefix botname for LUIS app names #831

Closed
vishwacsena opened this issue Dec 7, 2018 · 0 comments · Fixed by #832
Closed

MSBOT: Do not prefix botname for LUIS app names #831

vishwacsena opened this issue Dec 7, 2018 · 0 comments · Fixed by #832
Labels
4.2 December 15, 2018 Release P0 Must Fix. Release-blocker

Comments

@vishwacsena
Copy link
Contributor

Tool

Name: MSBOT
Version: 4.2.0-103 (myget)
OS: Win10

Describe the bug

msbot clone prefixes botname to any LUIS application created. This is inconsistent with the rest of the service names choosen by MSBOT and this also breaks any code that depends on loading a service configuration by name.

To Reproduce

Steps to reproduce the behavior:

  1. run msbot clone to clone a bot that includes a LUIS model
  2. notice that the LUIS model was created with _

Expected behavior

MSBot clone does not add as prefix to LUIS models. Instead if there is an existing LUIS model found by that name, clone should fail gracefully.

[bug]

@vishwacsena vishwacsena added 4.2 December 15, 2018 Release P0 Must Fix. Release-blocker labels Dec 7, 2018
vishwacsena pushed a commit that referenced this issue Dec 7, 2018
vishwacsena added a commit that referenced this issue Dec 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
4.2 December 15, 2018 Release P0 Must Fix. Release-blocker
Projects
None yet
1 participant