Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Uneven NumberPad Margin in Converter Mode #87

Closed
LanceMcCarthy opened this issue Mar 1, 2019 · 4 comments · Fixed by #566
Closed

Uneven NumberPad Margin in Converter Mode #87

LanceMcCarthy opened this issue Mar 1, 2019 · 4 comments · Fixed by #566
Assignees
@HowardWolosky
Labels
Area: User Experience Issue primarily affects end user experience and are not covered by other areas fixed Pri: 3

Comments

@LanceMcCarthy
Copy link
Contributor

Describe the bug
Margin around the number pad should be of equal value.

Steps To Reproduce

  1. Go to any converter
  2. Decrease window width until the vertical layout VisualState is triggered

** Screenshot **
Observe the following layout

image

Expected behavior
Padding should be equal

Recommended Solution
There are two options:

  1. Decrease Right and Left margin to match the bottom (this would emulate the padding used on the main calculator interface)
  2. Increase the bottom margin to match the sides.

Device and Application Information

  • OS Build: 18346
  • Architecture: x64
  • Application Version: 10.1812.10048.0
@MicrosoftIssueBot
Copy link
Collaborator

This is your friendly Microsoft Issue Bot. I've seen this issue come in and have gone to tell a human about it.

@MicrosoftIssueBot MicrosoftIssueBot added triage needed Area: User Experience Issue primarily affects end user experience and are not covered by other areas Pri: 2 labels Mar 1, 2019
@grochocki grochocki added triage approved Issue has been approved by Calculator team member and removed triage needed labels Mar 2, 2019
@grochocki
Copy link
Contributor

Good catch! Also, I really appreciate your thoroughness when filing this issue. I would also propose maybe using the same margin as other calculator modes.

image

That might make the number pad buttons feel a little too stretched out, though. Thoughts?

@MicrosoftIssueBot MicrosoftIssueBot added the Bug Issue is a bug label Mar 2, 2019
@LanceMcCarthy
Copy link
Contributor Author

Yep that's the first option.

It's a little harder to see in dark theme, but I suspect the thin bottom margin on the converter pad is the same margin used all the way around the normal mode's number pad

@grochocki
Copy link
Contributor

Ah, yep. Probably just an optical illusion. In that case, I would go with the first option.

HowardWolosky added a commit to HowardWolosky/calculator that referenced this issue Jun 24, 2019
@HowardWolosky
Ensure consistent margins/padding with currency converter keypad
95c44c4 
Simplifies the layout of `ConverterNumPad` to match that
seen of `NumpadPanel` in Calculator.xaml by using the same
static margin and removing the use of columns that had been used
for dynamic margins.

Fixes microsoft#87
@HowardWolosky HowardWolosky mentioned this issue Jun 24, 2019
Merged
@HowardWolosky HowardWolosky self-assigned this Jun 24, 2019
HowardWolosky added a commit that referenced this issue Jun 28, 2019
@HowardWolosky
Ensure consistent margins/padding with currency converter keypad (#566)
25708f0 
Simplifies the layout of `ConverterNumPad` to match that
seen of `NumpadPanel` in Calculator.xaml by using the same
static margin and removing the use of columns that had been used
for dynamic margins.

Fixes #87
@MicrosoftIssueBot MicrosoftIssueBot added fixed and removed triage approved Issue has been approved by Calculator team member labels Jun 28, 2019
@MicrosoftIssueBot MicrosoftIssueBot removed the Bug Issue is a bug label Mar 30, 2020
@microsoft microsoft locked as resolved and limited conversation to collaborators Dec 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@HowardWolosky HowardWolosky

Labels
Area: User Experience Issue primarily affects end user experience and are not covered by other areas fixed Pri: 3
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Ensure consistent margins/padding with currency converter keypad HowardWolosky/calculator
4 participants
@grochocki @LanceMcCarthy @HowardWolosky @MicrosoftIssueBot