Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update gradle-to-js #517

Merged
merged 2 commits into from
Sep 29, 2017
Merged

Update gradle-to-js #517

merged 2 commits into from
Sep 29, 2017

Conversation

danielkcz
Copy link
Contributor

@danielkcz danielkcz commented Sep 28, 2017

Important bugfix there ... ninetwozero/gradle-to-js#9

There is no changelog, but based on list of commits, there is not much of changes from the currently used 0.2.5

Edit: On another look seeing the last comment there, something might be broken. Consider this PR as a starting point then :)

@ruslan-bikkinin ruslan-bikkinin self-assigned this Sep 29, 2017
@ruslan-bikkinin
Copy link
Contributor

LGTM

@ruslan-bikkinin
Copy link
Contributor

ruslan-bikkinin commented Sep 29, 2017

But...
@FredyC i think we don't need those anymore: https://github.com/Microsoft/code-push/blob/master/cli/script/command-executor.ts#L978-L989

UPD i did it myself

@msftclas
Copy link

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

❌ FredyC sign now
You have signed the CLA already but the status is still pending? Let us recheck it.

@ruslan-bikkinin ruslan-bikkinin merged commit 9f67d9c into microsoft:master Sep 29, 2017
@danielkcz
Copy link
Contributor Author

@ruslan-bikkinin Thanks for sorting this out quickly. Point of that upstream PR was this error ninetwozero/gradle-to-js#8. Not a big deal as it can be fixed by little edit to gradle file, but is kinda annoying when encountered :)

@ruslan-bikkinin
Copy link
Contributor

@FredyC you are welcome)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants