Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to set colors above index 15 with OSC 4 #313

Closed
zadjii-msft opened this Issue Nov 26, 2018 · 5 comments

Comments

Projects
None yet
3 participants
@zadjii-msft
Copy link
Member

zadjii-msft commented Nov 26, 2018

From #81:

Conhost doesn't support setting color table entries above 130.

Here's xterm printing in 130 by default:
image

I couldn't get the syntax just right, but for example, you definitely can change the colors of the extended table:
image
Note how color 130 is now a black square, instead of the color it usually is

@zadjii-msft zadjii-msft added the conhost label Nov 26, 2018

@zadjii-msft zadjii-msft added this to the 19H1 milestone Nov 26, 2018

@zadjii-msft zadjii-msft self-assigned this Nov 26, 2018

@zadjii-msft

This comment has been minimized.

Copy link
Member Author

zadjii-msft commented Nov 26, 2018

MSFT:19723934

@miniksa

This comment has been minimized.

Copy link
Member

miniksa commented Jan 18, 2019

I checked this morning and this fix should be in Insiders builds 18312 and higher (build on or after 2019-01-04).

@miniksa miniksa closed this Jan 18, 2019

@DHowett-MSFT

This comment has been minimized.

Copy link
Member

DHowett-MSFT commented Jan 18, 2019

This one's a little funny, actually. Most of the fix is in 18312, but it'll only work for colors 0-99. Colors 100-255 will probably be in whatever insider build comes next.

@miniksa miniksa reopened this Jan 18, 2019

@miniksa

This comment has been minimized.

Copy link
Member

miniksa commented Jan 18, 2019

Yes, sorry, this one had two changelists on it. It's also inbound.

@DHowett-MSFT

This comment has been minimized.

Copy link
Member

DHowett-MSFT commented Feb 8, 2019

This is now fully supported as of insider's build 18334.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.