Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Syntax highlighting support #682

Closed
ibuziuk opened this issue Feb 18, 2019 · 4 comments
Closed

Syntax highlighting support #682

ibuziuk opened this issue Feb 18, 2019 · 4 comments

Comments

@ibuziuk
Copy link

ibuziuk commented Feb 18, 2019

Syntax highlighting is currently out of scope of the LSP specification. This means that syntax colouring is still provided internally by IDE (e.g. xtext for Eclipse IDE) and there is no unified / standard way for providing default syntax scheme as part of language server. The proposal is to provide some specification in LSP in order to make syntax highlighting a part of the protocol. The most trivial implementation might be hex-based e.g.

"const" : "#00ff00" // green
"for" : "#0000ff" // blue
"int" : "#ffff00" // yellow
@ibuziuk
Copy link
Author

ibuziuk commented Feb 18, 2019

oh, probably a duplicate of #513

@mickaelistria
Copy link

FWIW, Eclipse IDE supports TextMate grammars, so do most other tools these days. XText could.consoder generating a Textmate grammars for its DSL to have portable syntax highlighting.
While syntax highlighting would make some sense in the protocol, textmate grammars are a decent enough workaround to not make it high priority.

@ibuziuk
Copy link
Author

ibuziuk commented Feb 18, 2019

well, it looks like there are already a few LSP related issues opened which indicates traction for making syntax highlighting a part of the protocol:

@dbaeumer
Copy link
Member

I will mark this as a dup of #513 since having this will allow syntax highlighting as well (and we will not have two different approaches).

In general it is our expierence that syntax highlighting must be fast and it best done inside the editor itself. So requesting this from the server might not be optimal.

@vscodebot vscodebot bot locked and limited conversation to collaborators Jun 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants