Team decided to do a breaking change in getErrorReport #306
Conversation
The sync version is no longer available as a public method, and the async method loses its suffix.
|
Hi @guperrot, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
TTYL, MSBOT; |
| @@ -55,16 +56,15 @@ protected void onCreate(Bundle savedInstanceState) { | |||
| MobileCenter.start(getApplication(), getAppSecret(), Analytics.class, Crashes.class); | |||
|
|
|||
| Log.i(LOG_TAG, "Crashes.hasCrashedInLastSession=" + Crashes.hasCrashedInLastSession()); | |||
| new AsyncTask<Void, Void, Void>() { | |||
| Crashes.getLastSessionCrashReport(new ResultCallback<ErrorReport>() { | |||
There was a problem hiding this comment.
You should wait for new binaries for this change. We don't have this method available in jcenter.
| */ | ||
| @Nullable | ||
| @WorkerThread | ||
| public static ErrorReport getLastSessionCrashReport() { |
There was a problem hiding this comment.
Instead of this, can you call getInstance().getInstanceLastSessionCrashReport() directly from Xamarin?
There was a problem hiding this comment.
Maybe not because it is private?
There was a problem hiding this comment.
I have to check something before I can answer that.
guperrot
force-pushed
the
error_report_async_api_changes
branch
from
0b43b3c
to
4180f41
Compare
|
|
||
| import static com.microsoft.azure.mobile.sasquatch.activities.MainActivity.LOG_TAG; | ||
|
|
||
| public class GetLastSessionErrorReportFeatureTest { |
There was a problem hiding this comment.
Do you really want to have Test at the end of the class name?
There was a problem hiding this comment.
Yeah, it's a feature test, the one for get last session error report. So it's a get last session error report feature test.
Current coverage is 100% (diff: 100%)@@ develop #306 diff @@
=====================================
Files 60 60
Lines 2725 2725
Methods 0 0
Messages 0 0
Branches 499 499
=====================================
Hits 2725 2725
Misses 0 0
Partials 0 0
|
The sync version is no longer available as a public method, and the async method loses its suffix.