Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support React Native 0.40 (in a backward compatible way) #16

Merged
merged 5 commits into from Jan 10, 2017

Conversation

BretJohnson
Copy link
Member

No description provided.

to test the SDK with newer & older versions of RN, ensuring we work both
pre & post the React #import namespace change, in 0.40
and our own header files, to be included with the namespace to support the React Native 0.40 breaking changes.
We also still include headers the old way, by doing a #if __has_include check, in order to support pre RN 0.40 with
the same SDK code base.
@msftclas
Copy link

Hi @BretJohnson, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!


It looks like you're a Microsoft contributor (Bret Johnson). If you're full-time, we DON'T require a Contribution License Agreement. If you are a vendor, please DO sign the electronic Contribution License Agreement. It will take 2 minutes and there's no faxing! https://cla.microsoft.com.

TTYL, MSBOT;

@BretJohnson BretJohnson changed the title Support rn v40 Support React Native 0.40 (in a backward compatible way) Jan 10, 2017
@BretJohnson BretJohnson merged commit 0888f04 into master Jan 10, 2017
@BretJohnson BretJohnson deleted the support-rn-v40 branch January 10, 2017 02:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants