Add support for using webpack process:'mock'

[wysisoft]

Does the paste command not work in any way for anyone else? I'm using this plugin with vue cli and a very vanilla example with 0.13.1 or 0.13.0 and paste does not work in any way?

[alexdima]

Does Paste work for you at https://microsoft.github.io/monaco-editor/ ?

[wysisoft]

It does - I think this relates only to the webpack version. I tried in all browsers, with a very vanilla example of a hello world vue-cli project and monaco-editor and this plugin. I found that the Ctrl-V Keydown was suppressing default, and if i stopped it from suppressing default, the textarea onpaste event fired. If i'm the only one with this problem, I guess nevermind...

[alexdima]

How do you configure the plugin when you build the editor? Do you specify only a subset of features ?

[dsedmak]

@wysisoft I'm having the same problem. Could you describe your solution a bit?
@alexandrudima Here is how I'm configuring the plugin:

const MonacoWebpackPlugin = require("monaco-editor-webpack-plugin");
module.exports = {
  configureWebpack: {
    plugins: [new MonacoWebpackPlugin({
      languages:[],
      features:[]
    })]
  }
};

Same thing happens if I don't specify options at all.

[wysisoft]

find this method in the ESM directory of the monaco editor folder, inside node_modules. function StandaloneKeybindingService(contextKeyService, commandService, telemetryService, notificationService, domNode) { var _this = _super.call(this, contextKeyService, commandService, telemetryService, notificationService) || this; _this._cachedResolver = null; _this._dynamicKeybindings = []; _this.toDispose.push(dom.addDisposableListener(domNode, dom.EventType.KEY_DOWN, function (e) { var keyEvent = new StandardKeyboardEvent(e); var shouldPreventDefault = _this._dispatch(keyEvent, keyEvent.target); //start of my fix this allows ctrl-v to cause a paste if(e.code == 'KeyV' && e.ctrlKey == true){ shouldPreventDefault = false; } //end of my fix if (shouldPreventDefault) { keyEvent.preventDefault(); } })); return _this; }

…

On Wed, Jul 4, 2018 at 6:24 AM dsedmak ***@***.***> wrote: @wysisoft <https://github.com/wysisoft> I'm having the same problem. Could you describe your solution a bit? @alexandrudima <https://github.com/alexandrudima> Here is how I'm configuring the plugin: const MonacoWebpackPlugin = require("monaco-editor-webpack-plugin");module.exports = { configureWebpack: { plugins: [new MonacoWebpackPlugin({ languages:[], features:[] })] } }; Same thing happens without specifying options at all. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#17 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AOeY7CfvCUYBjWvY0RFYDL5afTa1i8a4ks5uDLQKgaJpZM4Uh7Wh> .

[wysisoft]

Note that I ended up bailing on webpacking monaco - it creates a very large bundle, and it becomes really difficult to debug even when I put in debugger statements.

[ijse]

I find out it is relative with platform detecting. It misunderstand that is running on native environment.

[wysisoft]

Are you actually use webpack with monaco? On my end, tree shaking wasn't working and it was a 4 MB bundle?

[ijse]

yes for now. in my circumstance it's ok. How do you solve the bundle size problem?

[ijse]

after travelling in source codes. I find the problem is relative with this setting in webpack.config.js:

{ 
  node: {
    process: 'mock',
  },
}

These will add process in global, and process.platform='browser'. while typeof process === 'object' && typeof process.platform === 'string', monaco will consider this is in Linux OS and is native environment which is wrong.

[wysisoft]

Good find on the true cause.
I moved away from webpack for this project. I am modifying monaco source code at certain points, and the bundle was too difficult to debug.

[ijse]

I debug by adding debugger in node_modules/monaco-editor/esm/vs/*.js file.

[wysisoft]

is it always caught? Chrome debugger would not catch my breakpoints for example, in the suggestion module

[alexdima]

This should work fine now.