Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi-part IME compositions reset cursor in Edge #339

Closed
Tyriar opened this issue Jan 24, 2017 · 3 comments
Closed

Multi-part IME compositions reset cursor in Edge #339

Tyriar opened this issue Jan 24, 2017 · 3 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug help wanted Issues identified as good community contribution opportunities verified Verification succeeded
Milestone

Comments

@Tyriar
Copy link
Member

Tyriar commented Jan 24, 2017

Testing microsoft/vscode#19061

monaco-editor npm version: d38a5e5
Browser: Edge 38.14393.0.0
OS: Windows 10

Related to #320 but the "collapsing" happens when you switch some characters to kanji and start a new string with the Microsoft Japanese IME.

Turn on IME, type "watashi" (わたし):

image

Press space to confirm 私:

image

Type "ha" (は), it incorrectly overrides 私:

image

Pressing enter to confirm the composition results in the correct string:

image


This is vscode's behavior:

image

@alexdima alexdima added bug Issue identified by VS Code Team member as probable bug help wanted Issues identified as good community contribution opportunities labels Jan 25, 2017
@alexdima alexdima added this to the Backlog milestone Jan 25, 2017
@rebornix
Copy link
Member

IE and Edge are doing differently from Chrome(not v55, v56)/Safari/Firefox about composition update:

In Chrome/Safari/Firefox, type watashi first, you can get composition update of わたし and then if you press ha, and you'll get composition update of わたしは if you don't press enter to confirm わたし.

However in Edge/IE, type watashi first, you can get composition update of わたし and then if you press ha, and you'll get composition update of は **even if** you don't press enter to confirm わたし`.

Here again we have to rely on textarea to get the correct composition input. The fix is clean however it's making our composition logic really complex.

@weinand
Copy link

weinand commented Apr 26, 2017

This now works in VSC 1.12.0 on Windows 10 in Edge browser.

@weinand weinand added the verified Verification succeeded label Apr 26, 2017
@bpasero
Copy link
Member

bpasero commented Apr 26, 2017

Also seems to be working in Windows 10 VSC standalone.

@vscodebot vscodebot bot locked and limited conversation to collaborators Oct 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug help wanted Issues identified as good community contribution opportunities verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

5 participants