Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hover widget shows no text in Safari 10.1 #408

Closed
sandyarmstrong opened this issue Apr 4, 2017 · 2 comments
Closed

Hover widget shows no text in Safari 10.1 #408

sandyarmstrong opened this issue Apr 4, 2017 · 2 comments
Labels
bug Issue identified by VS Code Team member as probable bug safari

Comments

@sandyarmstrong
Copy link
Member

sandyarmstrong commented Apr 4, 2017

monaco-editor version: 0.8.1 (and also whatever's on the official playground)
Browser: Safari 10.1
OS: macOS 10.12.4

Steps to reproduce

  1. Open https://microsoft.github.io/monaco-editor/playground.html
  2. Hover over any element that should show a hover tooltip.

Expected results

Hover widget tooltip shows.

Actual results

Empty box of the correct size shows, but text is not visible.

Workaround

Click hover widget.

Notes

From what I can tell this worked fine in Safari 10.0, but last week 10.1 was released and broke this.

It is also broken in WebKit apps on macOS 10.12.4 (but I believe works on 10.11 and earlier 10.12 releases).

@sandyarmstrong
Copy link
Member Author

sandyarmstrong commented Apr 4, 2017

This seems to be some sort of animation regression. I'm now using this workaround:

.monaco-editor .monaco-editor-hover {
    animation: none !important;
}

In the playground, this change only seems to work on the left editor. I guess that has something to do with the iframe'd nature of the other editor?

@sandyarmstrong sandyarmstrong changed the title Signature Help shows no text in Safari 10.1 Hover widget shows no text in Safari 10.1 Apr 4, 2017
@rebornix
Copy link
Member

It shares the same root cause as #417.

@rebornix rebornix added duplicate safari bug Issue identified by VS Code Team member as probable bug labels Apr 13, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Oct 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug safari
Projects
None yet
Development

No branches or pull requests

2 participants