This repository has been archived by the owner on Nov 5, 2021. It is now read-only.
[JS/TS] Add support for alternative octal integer literal syntax #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rebornix
reviewed
Oct 10, 2018
| @@ -146,7 +146,7 @@ export const language = { | |||
| [/(@digits)[eE]([\-+]?(@digits))?/, 'number.float'], | |||
| [/(@digits)\.(@digits)([eE][\-+]?(@digits))?/, 'number.float'], | |||
| [/0[xX](@hexdigits)/, 'number.hex'], | |||
| [/0(@octaldigits)/, 'number.octal'], | |||
| [/0[oO]?(@octaldigits)/, 'number.octal'], | |||
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
according to the ECMAScript spec octal integer literals can also be of the form
0o123or0O123. This PR adds support for that syntax and also adds some more tests for hex and binary integer literals.Thanks!