Porting Microsoft.Build to .NET Core #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rt some of the code using these features to .NET Core.
…-> Dispose, Converter -> Func, reflection)
|
Hi @dsplaisted, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution! The agreement was validated by .NET Foundation and real humans are currently evaluating your PR. TTYL, DNFBOT; |
| // NOTE: This is safe to do because we have specified long-running so we get our own new thread. | ||
| string threadName = "RequestBuilder thread"; | ||
|
|
||
| #if FEATURE_APARTMENT_STATE | ||
| if (Thread.CurrentThread.GetApartmentState() == ApartmentState.STA) | ||
| { | ||
| // NOTE: This is safe to do because the STA scheduler always gives us our own new thread. | ||
| Thread.CurrentThread.Name = "RequestBuilder STA thread"; |
There was a problem hiding this comment.
Shouldn't this be threadName = "RequestBuilder STA thread";?
There was a problem hiding this comment.
Shouldn't this be
threadName = "RequestBuilder STA thread";?
Yes, good catch!
…essfully, fix thread name in RequestBuilder
| if (aCulture.LCID != bCulture.LCID) | ||
| { | ||
| return false; | ||
| } | ||
|
|
||
| return true; | ||
| #else | ||
| return CultureInfo?.Name == that.CultureInfo?.Name; |
There was a problem hiding this comment.
Guess we're going C# 6 now :)
There was a problem hiding this comment.
Unless anyone has any objections... :-)
|
LGTM |
dsplaisted
added a commit
that referenced
this pull request
Aug 19, 2015
Porting Microsoft.Build to .NET Core
ghost
mentioned this pull request
radical
added a commit
to radical/msbuild
that referenced
this pull request
Dec 4, 2019
[mono/master] Update from upstream master and update SDKs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Progress towards getting Microsoft.Build to compile for .NET Core