More porting Microsoft.Build to .NET Core #158
Conversation
…ateDotNet in NodePacketTranslator
…ce. Port to .NET Core. Other minor porting.
| internal static partial class FileUtilities | ||
| { | ||
| // .NET Core doesn't currently have APIs to get the "special" folders (ie the ones defined in the Environment.SpecialFolder enum) | ||
| // The code here is mostly copied out of the .NET reference source for this functionality |
There was a problem hiding this comment.
Are you taking stuff from https://github.com/Microsoft/referencesource or http://referencesource.microsoft.com? The latter isn't MIT licensed.
There was a problem hiding this comment.
@akoeplinger Excellent point!
This PR is provided as part of my job at Microsoft, who is the copyright holder on the code. By providing this PR, we're licensing the code submitted in this PR under the license of this project, which is MIT.
In this case, the code copied from the reference source was already part of the MIT-licensed reference source at GitHub.
There was a problem hiding this comment.
Thanks for clarifying 👍 I know you're an MS employee so I just wanted to have something on record that clarifies the origin of the code, licensing is hard 😄
|
LGTM. |
More porting Microsoft.Build to .NET Core
More progress towards getting Microsoft.Build to compile for .NET Core