New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More porting Microsoft.Build to .NET Core #158

Merged
merged 9 commits into from Aug 21, 2015

Conversation

Projects
None yet
4 participants
@dsplaisted
Member

dsplaisted commented Aug 21, 2015

More progress towards getting Microsoft.Build to compile for .NET Core

internal static partial class FileUtilities
{
// .NET Core doesn't currently have APIs to get the "special" folders (ie the ones defined in the Environment.SpecialFolder enum)
// The code here is mostly copied out of the .NET reference source for this functionality

This comment has been minimized.

@akoeplinger

akoeplinger Aug 21, 2015

Member

Are you taking stuff from https://github.com/Microsoft/referencesource or http://referencesource.microsoft.com? The latter isn't MIT licensed.

@akoeplinger

akoeplinger Aug 21, 2015

Member

Are you taking stuff from https://github.com/Microsoft/referencesource or http://referencesource.microsoft.com? The latter isn't MIT licensed.

This comment has been minimized.

@dsplaisted

dsplaisted Aug 21, 2015

Member

@akoeplinger Excellent point!

This PR is provided as part of my job at Microsoft, who is the copyright holder on the code. By providing this PR, we're licensing the code submitted in this PR under the license of this project, which is MIT.

In this case, the code copied from the reference source was already part of the MIT-licensed reference source at GitHub.

@dsplaisted

dsplaisted Aug 21, 2015

Member

@akoeplinger Excellent point!

This PR is provided as part of my job at Microsoft, who is the copyright holder on the code. By providing this PR, we're licensing the code submitted in this PR under the license of this project, which is MIT.

In this case, the code copied from the reference source was already part of the MIT-licensed reference source at GitHub.

This comment has been minimized.

@akoeplinger

akoeplinger Aug 21, 2015

Member

Thanks for clarifying 👍 I know you're an MS employee so I just wanted to have something on record that clarifies the origin of the code, licensing is hard 😄

@akoeplinger

akoeplinger Aug 21, 2015

Member

Thanks for clarifying 👍 I know you're an MS employee so I just wanted to have something on record that clarifies the origin of the code, licensing is hard 😄

@rainersigwald

This comment has been minimized.

Show comment
Hide comment
@rainersigwald

rainersigwald Aug 21, 2015

Contributor

LGTM.

Contributor

rainersigwald commented Aug 21, 2015

LGTM.

dsplaisted added a commit that referenced this pull request Aug 21, 2015

Merge pull request #158 from dsplaisted/netcore-port
More porting Microsoft.Build to .NET Core

@dsplaisted dsplaisted merged commit 9987c90 into Microsoft:xplat Aug 21, 2015

1 check failed

default Build finished. No test results found.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment