Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work around #1675 for C++ Code Analysis scenarios #1699

Merged
merged 1 commit into from Feb 14, 2017

Conversation

rainersigwald
Copy link
Member

This addresses the repro case for #1675, but not its root cause. By
providing a codeBase for the CA assemblies, we ensure that any running
MSBuild can find them when deserializing a log message.

This addresses the repro case for dotnet#1675, but not its root cause. By
providing a `codeBase` for the CA assemblies, we ensure that any running
MSBuild can find them when deserializing a log message.
@rainersigwald
Copy link
Member Author

@mavasani As discussed over email.

I was a bit confused about what assemblies to involve here. I first tried with just CodeAnalysis which seemed to work, but I observed FxCopTask load failures in the Fusion log. So I added that, at which point we crashed again due to failing to load CodeAnalysis.Sdk. So I went with all three. But I don't know if that's right.

@mavasani
Copy link
Member

@rainersigwald - that seems correct. FXCopTask assembly can be invoked from MSBuild and has a dependency on CodeAnalysis SDK.

@rainersigwald
Copy link
Member Author

One other thing--the plan for dev15 is that those assemblies are only ever serviced in-place in the VS folder, right? They won't ever be loaded from a NuGet package or something? This would break that.

@mavasani
Copy link
Member

Yes, these assemblies are not published via NuGet packages, they ship in the box.

@AndyGerlicher AndyGerlicher merged commit 66a9887 into dotnet:vs15-rtw Feb 14, 2017
@rainersigwald rainersigwald deleted the codeanalysis-codebase branch May 17, 2018 18:43
rainersigwald added a commit to rainersigwald/msbuild that referenced this pull request Feb 5, 2019
These assemblies have moved and versioned in dev16.

Update of the workaround for dotnet#1675 in dotnet#1699.
rainersigwald added a commit that referenced this pull request Feb 7, 2019
These assemblies have moved and versioned in dev16.

Update of the workaround for #1675 in #1699.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants