Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No stable release with PHP 7.3 #901

Closed
auroraeosrose opened this issue Dec 7, 2018 · 11 comments
Closed

No stable release with PHP 7.3 #901

auroraeosrose opened this issue Dec 7, 2018 · 11 comments

Comments

@auroraeosrose
Copy link

There are currently no stable (not pre-release) versions of this extension that support PHP 7.3
And there are multiple commits (with fixed issues) since the last pre-release version

Now that PHP 7.3 is released, the lack of a stable version of this extension is blocking our upgrading to the most recent version of PHP in production.

@yitam
Copy link
Contributor

yitam commented Dec 7, 2018

hi @auroraeosrose we are going to release a preview soon and plan to add another feature before a stable release in early 2019.

@esetnik
Copy link

esetnik commented Dec 10, 2018

I just got hit with this when using FROM php:7-stretch docker image. Since it just changed to PHP 7.3 any new image builds now break on the following step:

RUN pecl install sqlsrv pdo_sqlsrv && \
  docker-php-ext-enable sqlsrv pdo_sqlsrv

Log:

Step 5/19 : RUN pecl install sqlsrv pdo_sqlsrv &&   docker-php-ext-enable sqlsrv pdo_sqlsrv
 ---> Running in 47fc5c35226f
downloading sqlsrv-5.3.0.tgz ...
Starting to download sqlsrv-5.3.0.tgz (173,492 bytes)
......................done: 173,492 bytes

Warning: "continue" targeting switch is equivalent to "break". Did you mean to use "continue 2"? in PEAR/PackageFile/v2/Validator.php on line 1933

Warning: "continue" targeting switch is equivalent to "break". Did you mean to use "continue 2"? in /usr/local/lib/php/PEAR/PackageFile/v2/Validator.php on line 1933
downloading pdo_sqlsrv-5.3.0.tgz ...
Starting to download pdo_sqlsrv-5.3.0.tgz (166,182 bytes)
...done: 166,182 bytes
33 source files, building
running: phpize
Configuring for:
PHP Api Version:         20180731
Zend Module Api No:      20180731
Zend Extension Api No:   320180731
building in /tmp/pear/temp/pear-build-defaultuseruQ60Hk/sqlsrv-5.3.0
running: /tmp/pear/temp/sqlsrv/configure --with-php-config=/usr/local/bin/php-config
checking for grep that handles long lines and -e... /bin/grep
checking for egrep... /bin/grep -E
checking for a sed that does not truncate output... /bin/sed
checking for cc... cc
checking whether the C compiler works... yes
checking for C compiler default output file name... a.out
checking for suffix of executables...
checking whether we are cross compiling... no
checking for suffix of object files... o
checking whether we are using the GNU C compiler... yes
checking whether cc accepts -g... yes
checking for cc option to accept ISO C89... none needed
checking how to run the C preprocessor... cc -E
checking for icc... no
checking for suncc... no
checking whether cc understands -c and -o together... yes
checking for system library directory... lib
checking if compiler supports -R... no
checking if compiler supports -Wl,-rpath,... yes
checking build system type... x86_64-pc-linux-gnu
checking host system type... x86_64-pc-linux-gnu
checking target system type... x86_64-pc-linux-gnu
checking for PHP prefix... /usr/local
checking for PHP includes... -I/usr/local/include/php -I/usr/local/include/php/main -I/usr/local/include/php/TSRM -I/usr/local/include/php/Zend -I/usr/local/include/php/ext -I/usr/local/include/php/ext/date/lib
checking for PHP extension directory... /usr/local/lib/php/extensions/no-debug-non-zts-20180731
checking for PHP installed headers prefix... /usr/local/include/php
checking if debug is enabled... no
checking if zts is enabled... no
checking for re2c... re2c
checking for re2c version... 0.16 (ok)
checking for gawk... no
checking for nawk... nawk
checking if nawk is broken... no
checking whether to enable sqlsrv functions... yes, shared
checking for SQLSRV headers... /tmp/pear/temp/sqlsrv/shared/
checking for g++... g++
checking whether we are using the GNU C++ compiler... yes
checking whether g++ accepts -g... yes
checking how to run the C++ preprocessor... g++ -E
checking for ld used by cc... /usr/bin/ld
checking if the linker (/usr/bin/ld) is GNU ld... yes
checking for /usr/bin/ld option to reload object files... -r
checking for BSD-compatible nm... /usr/bin/nm -B
checking whether ln -s works... yes
checking how to recognize dependent libraries... pass_all
checking for ANSI C header files... yes
checking for sys/types.h... yes
checking for sys/stat.h... yes
checking for stdlib.h... yes
checking for string.h... yes
checking for memory.h... yes
checking for strings.h... yes
checking for inttypes.h... yes
checking for stdint.h... yes
checking for unistd.h... yes
checking dlfcn.h usability... yes
checking dlfcn.h presence... yes
checking for dlfcn.h... yes
checking how to run the C++ preprocessor... g++ -E
checking the maximum length of command line arguments... 1572864
checking command to parse /usr/bin/nm -B output from cc object... ok
checking for objdir... .libs
checking for ar... ar
checking for ranlib... ranlib
checking for strip... strip
checking if cc supports -fno-rtti -fno-exceptions... no
checking for cc option to produce PIC... -fPIC
checking if cc PIC flag -fPIC works... yes
checking if cc static flag -static works... yes
checking if cc supports -c -o file.o... yes
checking whether the cc linker (/usr/bin/ld -m elf_x86_64) supports shared libraries... yes
checking whether -lc should be explicitly linked in... no
checking dynamic linker characteristics... GNU/Linux ld.so
checking how to hardcode library paths into programs... immediate
checking whether stripping libraries is possible... yes
checking if libtool supports shared libraries... yes
checking whether to build shared libraries... yes
checking whether to build static libraries... no

creating libtool
appending configuration tag "CXX" to libtool
checking for ld used by g++... /usr/bin/ld -m elf_x86_64
checking if the linker (/usr/bin/ld -m elf_x86_64) is GNU ld... yes
checking whether the g++ linker (/usr/bin/ld -m elf_x86_64) supports shared libraries... yes
checking for g++ option to produce PIC... -fPIC
checking if g++ PIC flag -fPIC works... yes
checking if g++ static flag -static works... yes
checking if g++ supports -c -o file.o... yes
checking whether the g++ linker (/usr/bin/ld -m elf_x86_64) supports shared libraries... yes
checking dynamic linker characteristics... GNU/Linux ld.so
(cached) (cached) checking how to hardcode library paths into programs... immediate
configure: creating ./config.status
config.status: creating config.h
running: make
/bin/bash /tmp/pear/temp/pear-build-defaultuseruQ60Hk/sqlsrv-5.3.0/libtool --mode=compile g++ -std=c++11 -I. -I/tmp/pear/temp/sqlsrv -DPHP_ATOM_INC -I/tmp/pear/temp/pear-build-defaultuseruQ60Hk/sqlsrv-5.3.0/include -I/tmp/pear/temp/pear-build-defaultuseruQ60Hk/sqlsrv-5.3.0/main -I/tmp/pear/temp/sqlsrv -I/usr/local/include/php -I/usr/local/include/php/main -I/usr/local/include/php/TSRM -I/usr/local/include/php/Zend -I/usr/local/include/php/ext -I/usr/local/include/php/ext/date/lib -I/tmp/pear/temp/sqlsrv/shared/  -DHAVE_CONFIG_H  -std=c++11 -D_FORTIFY_SOURCE=2 -O2 -fstack-protector   -c /tmp/pear/temp/sqlsrv/conn.cpp -o conn.lo
mkdir .libs
 g++ -std=c++11 -I. -I/tmp/pear/temp/sqlsrv -DPHP_ATOM_INC -I/tmp/pear/temp/pear-build-defaultuseruQ60Hk/sqlsrv-5.3.0/include -I/tmp/pear/temp/pear-build-defaultuseruQ60Hk/sqlsrv-5.3.0/main -I/tmp/pear/temp/sqlsrv -I/usr/local/include/php -I/usr/local/include/php/main -I/usr/local/include/php/TSRM -I/usr/local/include/php/Zend -I/usr/local/include/php/ext -I/usr/local/include/php/ext/date/lib -I/tmp/pear/temp/sqlsrv/shared/ -DHAVE_CONFIG_H -std=c++11 -D_FORTIFY_SOURCE=2 -O2 -fstack-protector -c /tmp/pear/temp/sqlsrv/conn.cpp  -fPIC -DPIC -o .libs/conn.o
In file included from /usr/local/include/php/Zend/zend.h:27:0,
                 from /usr/local/include/php/main/php.h:33,
                 from /tmp/pear/temp/sqlsrv/shared/core_sqlsrv.h:34,
                 from /tmp/pear/temp/sqlsrv/php_sqlsrv.h:25,
                 from /tmp/pear/temp/sqlsrv/conn.cpp:20:
/tmp/pear/temp/sqlsrv/shared/core_sqlsrv.h: In function 'void core::sqlsrv_array_init(sqlsrv_context&, zval*)':
/usr/local/include/php/Zend/zend_types.h:792:24: error: expected id-expression before 'do'
 #define ZVAL_ARR(z, a) do {      \
                        ^
/usr/local/include/php/Zend/zend_API.h:377:28: note: in expansion of macro 'ZVAL_ARR'
 #define array_init(arg)    ZVAL_ARR((arg), zend_new_array(0))
                            ^~~~~~~~
/tmp/pear/temp/sqlsrv/shared/core_sqlsrv.h:2380:20: note: in expansion of macro 'array_init'
         int zr = ::array_init(new_array);
                    ^~~~~~~~~~
Makefile:194: recipe for target 'conn.lo' failed
make: *** [conn.lo] Error 1
ERROR: `make' failed

For anyone that comes across this issue, you need to pin to PHP 7.2 e.g. FROM php:7.2-stretch until a stable sqlsrv is released which supports PHP 7.3.

@yitam
Copy link
Contributor

yitam commented Dec 10, 2018

Thanks for the tips, @esetnik
As mentioned above, we are working hard to create a stable release that supports PHP 7.3 and in the meantime thanks for your patience.

@esetnik
Copy link

esetnik commented Jan 14, 2019

Is there any update on this?

@yitam
Copy link
Contributor

yitam commented Jan 14, 2019

We will release a stable version after ODBC driver 17.3 is officially released. Please stay tuned on their blog.

@David-Engel
Copy link
Contributor

The ODBC 17.3 release is currently targeting February so a stable PHP drivers release should follow behind shortly afterwards, following testing with the official ODBC 17.3 release.

@crisleiria
Copy link

Any news on this issue? Same error on pecl install sqlsrv pdo_sqlsrv
When trying to use PHP 7.3 on ubuntu 18.04. I had to downgrade to 7.2...

@david-puglielli
Copy link
Contributor

Newest stable release now available. Closing this issue.

@esetnik
Copy link

esetnik commented Feb 25, 2019

@David-Engel it looks like msodbcsql17-17.3 is still not available in the debian mirrors:

https://packages.microsoft.com/debian/9/prod/pool/main/m/msodbcsql17/

@David-Engel
Copy link
Contributor

David-Engel commented Feb 25, 2019

@esetnik Thanks. I know they were having issues publishing to the repo Friday. I'll ping them again today to see what's up.

Edit - Issues all weekend. Still trying.

@yitam
Copy link
Contributor

yitam commented Feb 26, 2019

FYI, @esetnik, odbc 17.3.1.1 is up now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants