Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix | Fixed PreparedStatement exception handling #1003

Merged
merged 5 commits into from
Apr 10, 2019
Merged

Conversation

ulvii
Copy link
Contributor

@ulvii ulvii commented Mar 22, 2019

Fixes #995, reverts #664.

When there is an exception in a result set, it should only be parsed when the cursor is moved to that result set. This PR also makes Statement and PreparedStatement behavior consistent with each other.

@codecov-io
Copy link

Codecov Report

Merging #1003 into dev will decrease coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev    #1003      +/-   ##
============================================
- Coverage     50.19%   50.13%   -0.06%     
+ Complexity     2885     2881       -4     
============================================
  Files           120      120              
  Lines         27989    27984       -5     
  Branches       4677     4675       -2     
============================================
- Hits          14050    14031      -19     
- Misses        11684    11696      +12     
- Partials       2255     2257       +2
Flag Coverage Δ Complexity Δ
#JDBC42 49.68% <ø> (-0.09%) 2840 <ø> (-6)
#JDBC43 50.05% <ø> (-0.12%) 2874 <ø> (-10)
Impacted Files Coverage Δ Complexity Δ
...m/microsoft/sqlserver/jdbc/SQLServerResultSet.java 43.75% <ø> (-0.3%) 317 <0> (-3)
...om/microsoft/sqlserver/jdbc/ReaderInputStream.java 43.95% <0%> (-3.3%) 15% <0%> (ø)
...rc/main/java/com/microsoft/sqlserver/jdbc/DDC.java 46.86% <0%> (-0.44%) 111% <0%> (-1%)
...ncurrentlinkedhashmap/ConcurrentLinkedHashMap.java 38.36% <0%> (-0.22%) 42% <0%> (-1%)
...in/java/com/microsoft/sqlserver/jdbc/IOBuffer.java 55.55% <0%> (-0.17%) 0% <0%> (ø)
...c/main/java/com/microsoft/sqlserver/jdbc/Util.java 62.93% <0%> (+0.43%) 92% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e432aa1...aa047ab. Read the comment docs.

@codecov-io
Copy link

codecov-io commented Mar 25, 2019

Codecov Report

Merging #1003 into dev will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev    #1003      +/-   ##
============================================
- Coverage     50.76%   50.73%   -0.04%     
+ Complexity     2960     2959       -1     
============================================
  Files           120      120              
  Lines         27999    27994       -5     
  Branches       4685     4683       -2     
============================================
- Hits          14215    14203      -12     
- Misses        11626    11638      +12     
+ Partials       2158     2153       -5
Flag Coverage Δ Complexity Δ
#JDBC42 50.29% <ø> (-0.06%) 2916 <ø> (-7)
#JDBC43 50.63% <ø> (-0.06%) 2957 <ø> (+2)
Impacted Files Coverage Δ Complexity Δ
...m/microsoft/sqlserver/jdbc/SQLServerResultSet.java 43.79% <ø> (-0.27%) 323 <0> (-1)
...om/microsoft/sqlserver/jdbc/ReaderInputStream.java 43.95% <0%> (-1.1%) 15% <0%> (ø)
...om/microsoft/sqlserver/jdbc/SQLServerBulkCopy.java 50.39% <0%> (-0.13%) 245% <0%> (-1%)
...in/java/com/microsoft/sqlserver/jdbc/IOBuffer.java 57.86% <0%> (-0.07%) 0% <0%> (ø)
...c/main/java/com/microsoft/sqlserver/jdbc/Util.java 63.79% <0%> (+0.43%) 96% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d436203...d2e6b9e. Read the comment docs.

@cheenamalhotra cheenamalhotra added this to the 7.3.1 milestone Mar 28, 2019
@cheenamalhotra cheenamalhotra added this to Under Peer Review in MSSQL JDBC Apr 9, 2019
cheenamalhotra
cheenamalhotra previously approved these changes Apr 9, 2019
lilgreenbird
lilgreenbird previously approved these changes Apr 9, 2019
rene-ye
rene-ye previously approved these changes Apr 9, 2019
peterbae
peterbae previously approved these changes Apr 10, 2019
@ulvii ulvii merged commit 727efcc into microsoft:dev Apr 10, 2019
MSSQL JDBC automation moved this from Under Peer Review to Closed/Merged PRs Apr 10, 2019
@ulvii ulvii deleted the issue995 branch April 10, 2019 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
MSSQL JDBC
  
Closed/Merged PRs
Development

Successfully merging this pull request may close these issues.

None yet

6 participants