Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests | Fix LobsStreamingTest to close all streams and resources appropriately #1019

Merged
merged 1 commit into from Apr 3, 2019

Conversation

cheenamalhotra
Copy link
Member

No description provided.

@codecov-io
Copy link

codecov-io commented Apr 3, 2019

Codecov Report

Merging #1019 into dev will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev    #1019      +/-   ##
============================================
+ Coverage     50.16%   50.18%   +0.01%     
  Complexity     2885     2885              
============================================
  Files           120      120              
  Lines         27989    27989              
  Branches       4677     4677              
============================================
+ Hits          14040    14045       +5     
+ Misses        11693    11687       -6     
- Partials       2256     2257       +1
Flag Coverage Δ Complexity Δ
#JDBC42 49.69% <ø> (-0.01%) 2839 <ø> (-4)
#JDBC43 50.09% <ø> (+0.03%) 2881 <ø> (+2) ⬆️
Impacted Files Coverage Δ Complexity Δ
...c/main/java/com/microsoft/sqlserver/jdbc/Util.java 62.5% <0%> (-0.44%) 91% <0%> (-1%)
...ncurrentlinkedhashmap/ConcurrentLinkedHashMap.java 39% <0%> (-0.22%) 43% <0%> (-1%)
...in/java/com/microsoft/sqlserver/jdbc/IOBuffer.java 55.55% <0%> (+0.06%) 0% <0%> (ø) ⬇️
...rc/main/java/com/microsoft/sqlserver/jdbc/DDC.java 47.3% <0%> (+0.43%) 112% <0%> (+1%) ⬆️
...a/com/microsoft/sqlserver/jdbc/PLPInputStream.java 60.94% <0%> (+1.18%) 35% <0%> (+1%) ⬆️
...om/microsoft/sqlserver/jdbc/ReaderInputStream.java 47.25% <0%> (+2.19%) 15% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a64e479...d998fbc. Read the comment docs.

@cheenamalhotra cheenamalhotra merged commit caddd83 into microsoft:dev Apr 3, 2019
@cheenamalhotra cheenamalhotra added this to the 7.3.1 milestone Apr 10, 2019
@lilgreenbird lilgreenbird added this to Closed/Merged PRs in MSSQL JDBC Apr 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
MSSQL JDBC
  
Closed/Merged PRs
Development

Successfully merging this pull request may close these issues.

None yet

3 participants