Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix | Fix SharedTimer implementation to use class level lock for thread safety #1046

Merged
merged 3 commits into from
May 15, 2019

Conversation

cheenamalhotra
Copy link
Member

Fixes #1040

@sehrope
Copy link
Contributor

sehrope commented Apr 24, 2019

The static isRunning() method should be updated to use the explicit lock object as well.

@sehrope
Copy link
Contributor

sehrope commented Apr 24, 2019

Actually maybe it doesn't need the explicit synchronized lock at all as it's accessing the volatile field.

The method level synchronized can be removed though as the only thing it would be synchronizing is concurrent callers to that one method.

@cheenamalhotra cheenamalhotra added this to Under Peer Review in MSSQL JDBC May 3, 2019
@cheenamalhotra cheenamalhotra merged commit 6c1b4b3 into microsoft:dev May 15, 2019
MSSQL JDBC automation moved this from Under Peer Review to Closed/Merged PRs May 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
MSSQL JDBC
  
Closed/Merged PRs
Development

Successfully merging this pull request may close these issues.

Hikari + MSSQL 7.2.1 having issues
7 participants