Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix | Fix issues with Login Timeout not getting applied appropriately. #1049

Merged
merged 5 commits into from
May 15, 2019

Conversation

cheenamalhotra
Copy link
Member

Fixes #1048

peterbae
peterbae previously approved these changes Apr 25, 2019
@codecov-io
Copy link

codecov-io commented Apr 26, 2019

Codecov Report

Merging #1049 into dev will increase coverage by 2.24%.
The diff coverage is 83.33%.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev    #1049      +/-   ##
============================================
+ Coverage     50.68%   52.92%   +2.24%     
- Complexity     3057     3138      +81     
============================================
  Files           119      119              
  Lines         27941    27944       +3     
  Branches       4668     4668              
============================================
+ Hits          14162    14790     +628     
+ Misses        11461    10927     -534     
+ Partials       2318     2227      -91
Impacted Files Coverage Δ Complexity Δ
.../com/microsoft/sqlserver/jdbc/SQLServerDriver.java 83.18% <83.33%> (+0.03%) 37 <0> (+1) ⬆️
...rc/main/java/com/microsoft/sqlserver/jdbc/DDC.java 47.51% <0%> (-0.44%) 111% <0%> (-1%)
...ncurrentlinkedhashmap/ConcurrentLinkedHashMap.java 38.79% <0%> (-0.22%) 43% <0%> (ø)
...n/java/com/microsoft/sqlserver/jdbc/Parameter.java 67.41% <0%> (-0.21%) 64% <0%> (ø)
...oft/sqlserver/jdbc/SQLServerParameterMetaData.java 73.86% <0%> (+0.22%) 103% <0%> (ø) ⬇️
...rc/main/java/com/microsoft/sqlserver/jdbc/dtv.java 68.59% <0%> (+0.23%) 0% <0%> (ø) ⬇️
...om/microsoft/sqlserver/jdbc/SQLServerBulkCopy.java 51.56% <0%> (+0.3%) 255% <0%> (ø) ⬇️
...soft/sqlserver/jdbc/SQLServerDatabaseMetaData.java 36.81% <0%> (+0.46%) 69% <0%> (+1%) ⬆️
.../com/microsoft/sqlserver/jdbc/SQLServerSQLXML.java 12.69% <0%> (+0.79%) 9% <0%> (+1%) ⬆️
...va/com/microsoft/sqlserver/jdbc/SQLServerClob.java 33.59% <0%> (+1.18%) 4% <0%> (ø) ⬇️
... and 25 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 51d6c40...48aa95a. Read the comment docs.

@cheenamalhotra cheenamalhotra added this to the 7.3.1 milestone Apr 27, 2019
peterbae
peterbae previously approved these changes Apr 30, 2019
@cheenamalhotra cheenamalhotra added this to Under Peer Review in MSSQL JDBC May 3, 2019
rene-ye
rene-ye previously approved these changes May 10, 2019
@lilgreenbird lilgreenbird self-requested a review May 13, 2019 02:59
lilgreenbird
lilgreenbird previously approved these changes May 13, 2019
@cheenamalhotra cheenamalhotra merged commit 20c0b81 into microsoft:dev May 15, 2019
MSSQL JDBC automation moved this from Under Peer Review to Closed/Merged PRs May 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
MSSQL JDBC
  
Closed/Merged PRs
Development

Successfully merging this pull request may close these issues.

[BUG]loginTimeout in URL not valid if DriverManager.setLoginTimeout
6 participants