Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test | Fix DB Metadata tests + fix maven warnings + clean all objects #1060

Merged
merged 7 commits into from May 29, 2019

Conversation

cheenamalhotra
Copy link
Member

@cheenamalhotra cheenamalhotra commented May 18, 2019

The PR:

  • Fixes Database Metadata tests that expect existing table in target database.
  • Fixes Maven build warnings with JavaDocs
  • Cleans all remaining database objects in Junit Tests (User Defined Table Types (TVP), Stored Procedures, Scalar Functions)

@codecov-io
Copy link

codecov-io commented May 18, 2019

Codecov Report

❗ No coverage uploaded for pull request base (dev@56268e4). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##             dev    #1060   +/-   ##
======================================
  Coverage       ?   52.96%           
  Complexity     ?     3156           
======================================
  Files          ?      119           
  Lines          ?    28023           
  Branches       ?     4680           
======================================
  Hits           ?    14842           
  Misses         ?    10963           
  Partials       ?     2218
Impacted Files Coverage Δ Complexity Δ
.../microsoft/sqlserver/jdbc/SQLServerConnection.java 49.61% <ø> (ø) 395 <0> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 56268e4...9c9fb1f. Read the comment docs.

peterbae
peterbae previously approved these changes May 21, 2019
rene-ye
rene-ye previously approved these changes May 21, 2019
@cheenamalhotra cheenamalhotra dismissed stale reviews from rene-ye and peterbae via dd930b3 May 21, 2019 22:07
@cheenamalhotra cheenamalhotra added this to Under Peer Review in MSSQL JDBC May 22, 2019
@cheenamalhotra cheenamalhotra merged commit 6beb29a into microsoft:dev May 29, 2019
MSSQL JDBC automation moved this from Under Peer Review to Closed/Merged PRs May 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
MSSQL JDBC
  
Closed/Merged PRs
Development

Successfully merging this pull request may close these issues.

None yet

5 participants