BulkCopy ColumnMapping test #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
January 24, 2017 11:25
Add columnMappign junit tests
AfsanehR-zz
reviewed
Jan 26, 2017
| * @param expectedValue | ||
| * @param actualValue | ||
| */ | ||
| private void compareSourceDest(int dataType, Object expectedValue, Object actualValue){ |
There was a problem hiding this comment.
can we use the same method in BulkCopyTestUtil?
There was a problem hiding this comment.
yes it can be used, modified test code to use it
AfsanehR-zz
reviewed
Jan 27, 2017
| finally { | ||
| if(dropDest){ | ||
| stmt.dropTable(destinationTable); | ||
| con.close(); |
There was a problem hiding this comment.
let's close con and stmt out of if( dropDest ) check.
There was a problem hiding this comment.
The if(dropDest) condition is because some destination tables require further validation after performBulkCopy method.
i've moved con.close() to outside the if statement
AfsanehR-zz
approved these changes
Jan 27, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add junit test cases for bulkCopy column mapping