Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fips connection property #135

Merged
merged 3 commits into from
Feb 7, 2017
Merged

Add fips connection property #135

merged 3 commits into from
Feb 7, 2017

Conversation

v-nisidh
Copy link
Contributor

@v-nisidh v-nisidh commented Feb 5, 2017

Add bunch of negtive test cases & reduced property parameters in case installed certificate for FIPS enabled JVM

Add fips property whcih is very useful in case of installed
certificates.
@v-nisidh v-nisidh modified the milestone: 6.1.4 Feb 5, 2017
@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (dev@2779416). Click here to learn what that means.

@@          Coverage Diff           @@
##             dev     #135   +/-   ##
======================================
  Coverage       ?   27.31%           
  Complexity     ?     1132           
======================================
  Files          ?       95           
  Lines          ?    23268           
  Branches       ?     3870           
======================================
  Hits           ?     6356           
  Misses         ?    15625           
  Partials       ?     1287
Flag Coverage Δ Complexity Δ
#JDBC41 27.22% <61.29%> (?) 1127 <ø> (?)
#JDBC42 27.15% <61.29%> (?) 1130 <ø> (?)
Impacted Files Coverage Δ Complexity Δ
...om/microsoft/sqlserver/jdbc/SQLServerResource.java 100% <ø> (ø) 4 <ø> (?)
.../com/microsoft/sqlserver/jdbc/SQLServerDriver.java 70.97% <100%> (ø) 23 <ø> (?)
...in/java/com/microsoft/sqlserver/jdbc/IOBuffer.java 31.57% <57.14%> (ø) 0 <ø> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2779416...bff2c5b. Read the comment docs.

@v-nisidh v-nisidh merged commit 8a9ea96 into microsoft:dev Feb 7, 2017
@v-nisidh v-nisidh deleted the fips1.1 branch February 10, 2017 21:44
@v-nisidh
Copy link
Contributor Author

Thanks @ErikBergfurInfor for identifying missing implementation.

@v-nisidh
Copy link
Contributor Author

@ErikBergfurInfor I added above properties in SQLServerDataSource. Only change is I am using Boolean return value for getFips. I will create Pull Request to merge to dev after creating bunch of test cases.

ref: v-nisidh@6789957

@v-nisidh
Copy link
Contributor Author

@ErikBergfurInfor I merge above changes dev branch.

@ulvii ulvii mentioned this pull request Aug 12, 2017
@lilgreenbird lilgreenbird added this to Closed/Merged PRs in MSSQL JDBC Apr 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
MSSQL JDBC
  
Closed/Merged PRs
Development

Successfully merging this pull request may close these issues.

None yet

3 participants