Tvp name with stored procedure #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report@@ Coverage Diff @@
## dev #138 +/- ##
===========================================
- Coverage 27.21% 27.2% -0.01%
Complexity 1130 1130
===========================================
Files 95 95
Lines 23268 23268
Branches 3870 3870
===========================================
- Hits 6333 6331 -2
- Misses 15650 15652 +2
Partials 1285 1285
Continue to review full report at Codecov.
|
v-nisidh
reviewed
Feb 7, 2017
| public String getTvpName() { | ||
| return tvpName; | ||
| } | ||
|
|
||
| /** | ||
| * Retrieves the column meta data of this data table. | ||
| * | ||
| * @deprecated |
There was a problem hiding this comment.
Should give details like -> @deprecated As of release 6.1.x, replaced by {@link #[YOUR_METHOD]}
Also give reasons for deprecation which will useful for all contributors.
v-nisidh
suggested changes
Feb 7, 2017
There was a problem hiding this comment.
Added another comment saying:
Should give details like -> @deprecated As of release 6.1.x, replaced by {@link #[YOUR_METHOD]}
Also give reasons for deprecation which will useful for all contributors.
v-nisidh
reviewed
Feb 9, 2017
| @@ -2136,7 +2136,8 @@ public final void setStructured(int n, | |||
| String getTVPNameIfNull(int n, | |||
| String tvpName) throws SQLServerException { | |||
| if ((null == tvpName) || (0 == tvpName.length())) { | |||
There was a problem hiding this comment.
You can use StringUtils.isEmpty() method.
v-nisidh
approved these changes
Feb 9, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
instead of the public API setTVPName