Statement test cases #147

AfsanehR-zz · 2017-02-14T23:46:56Z

added unit test cases

codecov-io · 2017-02-14T23:53:38Z

Codecov Report

Merging #147 into dev will increase coverage by 2.31%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                dev     #147      +/-   ##
============================================
+ Coverage     27.32%   29.63%   +2.31%     
- Complexity     1142     1247     +105     
============================================
  Files            95       97       +2     
  Lines         23279    23303      +24     
  Branches       3870     3871       +1     
============================================
+ Hits           6360     6906     +546     
+ Misses        15641    15046     -595     
- Partials       1278     1351      +73

Flag	Coverage Δ	Complexity Δ
#JDBC41	`29.54% <ø> (+2.31%)`	`1242 <ø> (+104)`	✅
#JDBC42	`29.59% <ø> (+2.34%)`	`1247 <ø> (+107)`	✅

Impacted Files	Coverage Δ	Complexity Δ
src/main/java/microsoft/sql/DateTimeOffset.java	`37.14% <ø> (-2.86%)`	`8% <ø> (-2%)`
...rc/main/java/com/microsoft/sqlserver/jdbc/DDC.java	`22.54% <ø> (-0.45%)`	`36% <ø> (ø)`
...soft/sqlserver/jdbc/SQLServerDatabaseMetaData.java	`12.68% <ø> (-0.12%)`	`20% <ø> (ø)`
.../java/com/microsoft/sqlserver/jdbc/StreamDone.java	`50% <ø> (ø)`	`14% <ø> (+1%)`	✅
.../com/microsoft/sqlserver/jdbc/SqlFedAuthToken.java	`0% <ø> (ø)`	`0% <ø> (?)`
...microsoft/sqlserver/jdbc/SQLServerADAL4JUtils.java	`0% <ø> (ø)`	`0% <ø> (?)`
...m/microsoft/sqlserver/jdbc/SQLServerResultSet.java	`17.61% <ø> (+0.12%)`	`127% <ø> (ø)`	❌
...n/java/com/microsoft/sqlserver/jdbc/DataTypes.java	`68.01% <ø> (+0.16%)`	`0% <ø> (ø)`	❌
...in/java/com/microsoft/sqlserver/jdbc/IOBuffer.java	`31.88% <ø> (+0.97%)`	`0% <ø> (ø)`	❌
.../microsoft/sqlserver/jdbc/SQLServerConnection.java	`38.78% <ø> (+1.24%)`	`190% <ø> (+11%)`	✅
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3733637...30a4359. Read the comment docs.

v-nisidh

Still reviewing.

v-nisidh · 2017-02-15T19:04:09Z

src/test/java/com/microsoft/sqlserver/UnitStatement/MergeTest.java

+import com.microsoft.sqlserver.testframework.DBConnection;
+import com.microsoft.sqlserver.testframework.DBStatement;
+
+@RunWith(JUnitPlatform.class)


Better to have class & method level javadocs for all classes in this PR

v-nisidh · 2017-02-15T19:09:40Z

src/test/java/com/microsoft/sqlserver/UnitStatement/NamedParamMultiPart.java

+    @Test
+    @DisplayName("Named Param Multi Part Test")
+    public void datatypestest() throws Exception {
+        Connection Connection1 = DriverManager.getConnection(connectionString);


Do you really need connection1 & statment1? Because in AbstractTest we open one connection and accessible for all child classes. If somehow this connection fails due to may be wrong db connectionstring etc then all testcases which extends AbstractTest get skipped due to failure of setup method.

For specific testing it is goo to create your own connection & close that one but this case for connection1 we are not doing anything.

I see. This was part of the original test. Will remove it.

v-nisidh · 2017-02-15T19:17:02Z

src/test/java/com/microsoft/sqlserver/UnitStatement/PoolableTest.java

+    public  void poolableTest() throws SQLException, ClassNotFoundException {
+        Class.forName("com.microsoft.sqlserver.jdbc.SQLServerDriver");
+        Connection Connection1 = DriverManager.getConnection(connectionString);
+        Statement Statement151 = Connection1.createStatement();


Statement151. :) I think stmt might be more appropriate.

v-nisidh · 2017-02-15T19:25:05Z

src/test/java/com/microsoft/sqlserver/UnitStatement/CallableMixed.java

+@RunWith(JUnitPlatform.class)
+public class CallableMixed extends AbstractTest {
+    Connection connection1 = null;
+    Statement Statement151 = null;


Here I found non standard naming conventions. Instance Variables should start with lowercase. Generally identified as camelCase / lowerCamelCase. Look difference between connection1 and Stmatement151 / Driver1. Please change all instance variables with appropriate camelCase naming convention.

PS: Generally only static / final variables are in CAPS otherwise camelCase is pretty standard.

v-nisidh · 2017-02-15T19:27:41Z

src/test/java/com/microsoft/sqlserver/UnitStatement/CallableMixed.java

+
+    @Test
+    @DisplayName("Test CallableMix")
+    public void datatypestest() throws SQLException {


Function / Method name should be in lowerCamelCase / camelCase. This name should be dataTypesTest.

v-nisidh · 2017-02-15T19:38:48Z

src/test/java/com/microsoft/sqlserver/UnitStatement/CallableMixedTest.java

+     */
+    @Test
+    @DisplayName("Test CallableMix")
+    public void datatypestest() throws SQLException {


Unfortunately GitHub Reviews are not getting reflected after code file changes. :(

Here method name is not following lowerCamelCase nomenclature. It should be dataTypesTest

v-nisidh · 2017-02-15T19:44:01Z

src/test/java/com/microsoft/sqlserver/testframework/DBResultSet.java

-        //TODO: Check the intermittent verification error
-        //verifydata(ordinal, coercion, expectedData, retrieved);
+        // TODO: Check the intermittent verification error
+        // verifydata(ordinal, coercion, expectedData, retrieved);


do we really want to verify?

this is not related to this pr. we need to investigate this later for the intermittent bvt failures

v-nisidh · 2017-02-15T19:45:39Z

src/test/java/com/microsoft/sqlserver/testframework/DBConnection.java

+        return isSqlAzure;
+    }
+
+    public double serverversion() throws Exception {


We can give better function name like getServerVersion()

v-nisidh · 2017-02-15T19:48:46Z

src/test/java/com/microsoft/sqlserver/testframework/DBDriver.java

+    }
+
+    // Returns the default server version, not to be used in multiple server versions case
+    public static double serverversion() throws Exception {


I saw another serverversion() in DBConnection with different implementation. Which is right? Can we move this function in AbstractTest ?

v-nisidh · 2017-02-15T19:50:04Z

src/test/java/com/microsoft/sqlserver/UnitStatement/WrapperTest.java

+public class WrapperTest extends AbstractTest {
+
+    @Test
+    public void WrapTest() throws Exception {


Function name should be lowerCamelCase like

wrapTest

v-nisidh · 2017-02-15T20:01:47Z

src/test/java/com/microsoft/sqlserver/testframework/DBOptions.java

+    public  static final  String  SERVER_TYPE_SQL_SERVER = "SQL";
+    public  static final  String  SERVER_TYPE_SQL_AZURE  = "SQLAzure";
+
+    public static String servertype()


Formatting is not consistent for servertype method.

Method name should be like getServerType(...) for better naming convention.

Do you think this might be utility method and can be used by many test cases?

v-nisidh · 2017-02-15T20:03:33Z

src/test/java/com/microsoft/sqlserver/testframework/DBOptions.java

+        return _serverType;
+    }
+
+    public static String get(String property){


Really no need of this method. Instead of this method you can call Utils.getConfiguredProperty

v-nisidh · 2017-02-15T20:06:09Z

src/test/java/com/microsoft/sqlserver/UnitStatement/CallableMixedTest.java

+    @DisplayName("Test CallableMix")
+    public void datatypestest() throws SQLException {
+        connection1 = DriverManager.getConnection(connectionString);
+        Statement151 = connection1.createStatement();


All instance variable's name should be in lowerCamelCase while static final variable names should be in CAPS.

v-nisidh · 2017-02-15T21:33:27Z

src/test/java/com/microsoft/sqlserver/UnitStatement/PoolableTest.java

            isPoolable = ((SQLServerPreparedStatement) prepStmt).isPoolable();
            assertEquals(isPoolable, true, "SQLServerPreparedStatement should be Poolable by default");


-            CallableStatement CallableStatement1 = Connection1.prepareCall("{  ? = CALL " + "ProcName" + " (?, ?, ?, ?) }");
+            CallableStatement CallableStatement1 = connection.prepareCall("{  ? = CALL " + "ProcName" + " (?, ?, ?, ?) }");


CallableStatement1 should be callableStatement1. lowerCamelCase.

v-nisidh · 2017-02-15T21:35:14Z

src/test/java/com/microsoft/sqlserver/testframework/DBConnection.java

-    }
-
-    public double serverversion() throws Exception {
+    public double getServerversion() throws Exception {


Please change function name in lowerCamelCase i.e. getServerVersion

v-nisidh · 2017-02-15T21:38:33Z

src/test/java/com/microsoft/sqlserver/testframework/Utils.java

+                // default to SQL Server
+                _serverType = SERVER_TYPE_SQL_SERVER;
+            }
+            else if (serverTypeProperty.equalsIgnoreCase(SERVER_TYPE_SQL_AZURE))


Like to have constant on left hand side for comparison. Although it's good that you are checking serverTypeProperty is null nor not before any comparison.

added Statement unit test cases

8e036d5

added getproperty for checking jdbc version and java docs

c68cdca

v-nisidh suggested changes Feb 15, 2017

View reviewed changes

AfsanehR-zz added 3 commits February 15, 2017 13:19

post review changes

85b0c4b

post reviews commits

4f7c866

fixed the failure on travis-CI

741dd77

v-nisidh reviewed Feb 15, 2017

View reviewed changes

v-nisidh added this to the 6.1.4 milestone Feb 15, 2017

fixed the formatting

30a4359

v-nisidh approved these changes Feb 15, 2017

View reviewed changes

AfsanehR-zz merged commit 59a571a into microsoft:dev Feb 15, 2017

lilgreenbird added this to Closed/Merged PRs in MSSQL JDBC Apr 27, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Statement test cases #147

Statement test cases #147

AfsanehR-zz commented Feb 14, 2017

codecov-io commented Feb 14, 2017 •

edited

Loading

v-nisidh left a comment

v-nisidh Feb 15, 2017

v-nisidh Feb 15, 2017

AfsanehR-zz Feb 15, 2017

v-nisidh Feb 15, 2017

v-nisidh Feb 15, 2017

v-nisidh Feb 15, 2017

v-nisidh Feb 15, 2017

v-nisidh Feb 15, 2017

AfsanehR-zz Feb 15, 2017

v-nisidh Feb 15, 2017

v-nisidh Feb 15, 2017

v-nisidh Feb 15, 2017

v-nisidh Feb 15, 2017

v-nisidh Feb 15, 2017

v-nisidh Feb 15, 2017

v-nisidh Feb 15, 2017

v-nisidh Feb 15, 2017

v-nisidh Feb 15, 2017

Statement test cases #147

Statement test cases #147

Conversation

AfsanehR-zz commented Feb 14, 2017

codecov-io commented Feb 14, 2017 • edited Loading

Codecov Report

v-nisidh left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

codecov-io commented Feb 14, 2017 •

edited

Loading