make Azure Key Vault and Azure Active Directory Authentication Dependencies optional #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #148 +/- ##
============================================
+ Coverage 29.64% 29.69% +0.04%
+ Complexity 1249 1247 -2
============================================
Files 97 97
Lines 23303 23303
Branches 3871 3871
============================================
+ Hits 6909 6919 +10
+ Misses 15045 15027 -18
- Partials 1349 1357 +8
Continue to review full report at Codecov.
|
|
it's also for issue #17 |
ajlam
reviewed
Feb 16, 2017
README.md
Outdated
| @@ -87,7 +87,8 @@ The driver can be downloaded from the [Microsoft Download Center](https://www.mi | |||
| This project has following dependencies: | |||
|
|
|||
| Compile Time: | |||
| - `azure-keyvault` : Azure Key Vault Provider for Always Encrypted feature | |||
| - `azure-keyvault` : Azure Key Vault Provider for Always Encrypted feature (optinal) | |||
README.md
Outdated
| If you wish to limit the number of run-time dependencies, and your project does not require the features named above, you can explicitly exclude them by adding exclusion tag. | ||
| ***For Example:*** If you are not using *Always Encrypted Azure Key Vault feature* then you can exclude *azure-keyvault* dependency. Please see following snippet. | ||
| ### Azure Key Vault and Azure Active Directory Authentication Dependencies | ||
| Since the dependencies of ***Azure Key Vault*** and ***Azure Active Directory Authentication*** are optional, projects that require those 2 features need to redeclare the dependency explicitly in their pom files. |
There was a problem hiding this comment.
Let's just say "projects that require either of the two features need to explicitly declare the dependency in their pom file".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.