Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove obsolete methods from DriverJDBCVersion #187

Merged
merged 1 commit into from
Apr 4, 2017
Merged

Remove obsolete methods from DriverJDBCVersion #187

merged 1 commit into from
Apr 4, 2017

Conversation

marschall
Copy link
Contributor

The current codebase supports JDBC 4.1 and JDBC 4.2 specifications.
This means that there is no need to check if the driver supports JDBC
4.1 and lower since 4.1 is the earliest JDBC version implemented by the
driver. Therefore the methods in DriverJDBCVersion checkSupportsJDBC4
and checkSupportsJDBC41 are obsolete and can safely be removed.

Closes #61

The current codebase supports JDBC 4.1 and JDBC 4.2 specifications.
This means that there is no need to check if the driver supports JDBC
4.1 and lower since 4.1 is the earliest JDBC version implemented by the
driver. Therefore the methods in DriverJDBCVersion checkSupportsJDBC4
and checkSupportsJDBC41 are obsolete and can safely be removed.

Closes #61
@marschall
Copy link
Contributor Author

com.microsoft.sqlserver.jdbc.unit.statement.StatementTest.TCStatementParam.testRowError() fails on AppVeyor with

com.microsoft.sqlserver.jdbc.SQLServerException: Lock request time out period exceeded.

but succeeds on Travis

@v-nisidh
Copy link
Contributor

As Timeout timer is missing Exception is in random nature only on Appveyor, trying to close & reopen pull request.

@v-nisidh v-nisidh closed this Mar 14, 2017
@v-nisidh v-nisidh reopened this Mar 14, 2017
@codecov-io
Copy link

codecov-io commented Mar 14, 2017

Codecov Report

Merging #187 into dev will increase coverage by 1.53%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                dev     #187      +/-   ##
============================================
+ Coverage     31.43%   32.96%   +1.53%     
- Complexity     1359     1436      +77     
============================================
  Files            97       97              
  Lines         23359    23180     -179     
  Branches       3881     3812      -69     
============================================
+ Hits           7342     7641     +299     
+ Misses        14589    14005     -584     
- Partials       1428     1534     +106
Flag Coverage Δ Complexity Δ
#JDBC41 32.84% <ø> (+1.54%) 1427 <ø> (+78)
#JDBC42 32.92% <ø> (+1.55%) 1434 <ø> (+78)
Impacted Files Coverage Δ Complexity Δ
.../microsoft/sqlserver/jdbc/SQLServerConnection.java 39.93% <ø> (+0.22%) 206 <0> (+5)
.../microsoft/sqlserver/jdbc/SQLServerDataSource.java 40.74% <ø> (-0.51%) 54 <0> (ø)
...m/microsoft/sqlserver/jdbc/SQLServerStatement.java 57.95% <ø> (-0.2%) 128 <0> (+1)
.../com/microsoft/sqlserver/jdbc/SQLServerDriver.java 73.31% <ø> (-0.09%) 25 <0> (ø)
...soft/sqlserver/jdbc/SQLServerPooledConnection.java 51.06% <ø> (+1.06%) 12 <0> (ø)
.../com/microsoft/sqlserver/jdbc/SQLServerJdbc41.java 33.33% <ø> (-26.67%) 0 <0> (ø)
...oft/sqlserver/jdbc/SQLServerCallableStatement.java 13.81% <ø> (+0.39%) 39 <0> (ø)
...m/microsoft/sqlserver/jdbc/SQLServerResultSet.java 24.55% <ø> (+3.31%) 172 <0> (+16)
...va/com/microsoft/sqlserver/jdbc/SQLServerBlob.java 25% <ø> (+25%) 11 <0> (+11)
...soft/sqlserver/jdbc/SQLServerDatabaseMetaData.java 12.72% <ø> (-0.07%) 20 <0> (ø)
... and 24 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b647c1...575c9a5. Read the comment docs.

@ahmad-ibra ahmad-ibra self-assigned this Apr 3, 2017
@ahmad-ibra ahmad-ibra merged commit b2f5c37 into microsoft:dev Apr 4, 2017
@lilgreenbird lilgreenbird added this to Closed/Merged PRs in MSSQL JDBC Apr 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
MSSQL JDBC
  
Closed/Merged PRs
Development

Successfully merging this pull request may close these issues.

None yet

4 participants