Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typos in SQLServerConnectionPoolProxy #189

Merged
merged 1 commit into from
Mar 17, 2017
Merged

Typos in SQLServerConnectionPoolProxy #189

merged 1 commit into from
Mar 17, 2017

Conversation

marschall
Copy link
Contributor

There are a few easy to fix typos in SQLServerConnectionPoolProxy.

There are a few easy to fix typos in SQLServerConnectionPoolProxy.
@marschall
Copy link
Contributor Author

The AppVeyor builds fail because of

org.opentest4j.AssertionFailedError: Timeout timer is missing.

while the Travis builds succeed. I don't think this is caused by Javadoc changes.

@codecov-io
Copy link

codecov-io commented Mar 10, 2017

Codecov Report

Merging #189 into dev will decrease coverage by 0.04%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                dev     #189      +/-   ##
============================================
- Coverage     31.43%   31.38%   -0.05%     
+ Complexity     1359     1353       -6     
============================================
  Files            97       97              
  Lines         23359    23359              
  Branches       3881     3881              
============================================
- Hits           7342     7332      -10     
- Misses        14589    14599      +10     
  Partials       1428     1428
Flag Coverage Δ Complexity Δ
#JDBC41 31.29% <ø> (-0.01%) 1346 <ø> (-3)
#JDBC42 31.33% <ø> (-0.04%) 1353 <ø> (-3)
Impacted Files Coverage Δ Complexity Δ
...t/sqlserver/jdbc/SQLServerConnectionPoolProxy.java 12.62% <ø> (ø) 12 <0> (ø)
src/main/java/microsoft/sql/DateTimeOffset.java 37.14% <0%> (-2.86%) 8% <0%> (-2%)
...m/microsoft/sqlserver/jdbc/SQLServerResultSet.java 20.95% <0%> (-0.29%) 154% <0%> (-2%)
...om/microsoft/sqlserver/jdbc/SQLServerBulkCopy.java 44.8% <0%> (-0.22%) 182% <0%> (-2%)
...rc/main/java/com/microsoft/sqlserver/jdbc/DDC.java 24.1% <0%> (+0.44%) 36% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b647c1...8067170. Read the comment docs.

@v-nisidh v-nisidh merged commit 6ff1b6b into microsoft:dev Mar 17, 2017
@lilgreenbird lilgreenbird added this to Closed/Merged PRs in MSSQL JDBC Apr 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
MSSQL JDBC
  
Closed/Merged PRs
Development

Successfully merging this pull request may close these issues.

None yet

3 participants