Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test failures on pre-2016 servers #215

Merged
merged 1 commit into from
Mar 22, 2017
Merged

Fix test failures on pre-2016 servers #215

merged 1 commit into from
Mar 22, 2017

Conversation

gordthompson
Copy link
Contributor

Replace DROP TABLE IF EXISTS calls for compatibility with pre-2016 servers. ( Issue #214 )

@codecov-io
Copy link

codecov-io commented Mar 22, 2017

Codecov Report

Merging #215 into dev will increase coverage by 0.03%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                dev     #215      +/-   ##
============================================
+ Coverage     32.82%   32.85%   +0.03%     
  Complexity     1436     1436              
============================================
  Files            97       97              
  Lines         23383    23383              
  Branches       3889     3889              
============================================
+ Hits           7675     7683       +8     
+ Misses        14163    14150      -13     
- Partials       1545     1550       +5
Flag Coverage Δ Complexity Δ
#JDBC41 32.74% <ø> (+0.08%) 1432 <ø> (+6) ⬆️
#JDBC42 32.79% <ø> (+0.05%) 1435 <ø> (+1) ⬆️
Impacted Files Coverage Δ Complexity Δ
src/main/java/microsoft/sql/DateTimeOffset.java 37.14% <0%> (-2.86%) 8% <0%> (-2%)
...m/microsoft/sqlserver/jdbc/SQLServerResultSet.java 23.84% <0%> (-0.05%) 170% <0%> (ø)
...in/java/com/microsoft/sqlserver/jdbc/IOBuffer.java 36.54% <0%> (+0.2%) 0% <0%> (ø) ⬇️
...om/microsoft/sqlserver/jdbc/SQLServerBulkCopy.java 45.16% <0%> (+0.36%) 183% <0%> (+2%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b352610...a61c18d. Read the comment docs.

@xiangyushawn xiangyushawn merged commit 4b2a0ba into microsoft:dev Mar 22, 2017
@xiangyushawn
Copy link
Contributor

@gordthompson Thank you for your contribution. Now, all the tests succeed against SQL Server 2008 with your fix. Thank you.

@gordthompson gordthompson deleted the fix-tests-for-pre-2016-servers branch March 23, 2017 00:20
@lilgreenbird lilgreenbird added this to Closed/Merged PRs in MSSQL JDBC Apr 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
MSSQL JDBC
  
Closed/Merged PRs
Development

Successfully merging this pull request may close these issues.

None yet

3 participants