Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tvp precision fix #217

Merged
merged 3 commits into from
Mar 28, 2017
Merged

Conversation

xiangyushawn
Copy link
Contributor

for issue #211

@codecov-io
Copy link

codecov-io commented Mar 22, 2017

Codecov Report

Merging #217 into dev will increase coverage by 0.18%.
The diff coverage is 85.71%.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev     #217      +/-   ##
============================================
+ Coverage     32.86%   33.05%   +0.18%     
- Complexity     1442     1448       +6     
============================================
  Files            97       97              
  Lines         23383    23389       +6     
  Branches       3889     3890       +1     
============================================
+ Hits           7685     7731      +46     
+ Misses        14156    14107      -49     
- Partials       1542     1551       +9
Flag Coverage Δ Complexity Δ
#JDBC41 32.95% <85.71%> (+0.18%) 1443 <0> (+5) ⬆️
#JDBC42 32.93% <85.71%> (+0.18%) 1440 <0> (+6) ⬆️
Impacted Files Coverage Δ Complexity Δ
.../microsoft/sqlserver/jdbc/SQLServerDataColumn.java 77.77% <100%> (+2.77%) 1 <0> (ø) ⬇️
...m/microsoft/sqlserver/jdbc/SQLServerDataTable.java 46.55% <83.33%> (+12.31%) 12 <0> (+3) ⬆️
src/main/java/microsoft/sql/DateTimeOffset.java 37.14% <0%> (-2.86%) 8% <0%> (-2%)
...m/microsoft/sqlserver/jdbc/SQLServerResultSet.java 23.92% <0%> (-0.41%) 171% <0%> (-4%)
.../microsoft/sqlserver/jdbc/SQLServerConnection.java 40.19% <0%> (+0.08%) 206% <0%> (+2%) ⬆️
...om/microsoft/sqlserver/jdbc/SQLServerBulkCopy.java 45.16% <0%> (+0.21%) 183% <0%> (+1%) ⬆️
...n/java/com/microsoft/sqlserver/jdbc/Parameter.java 29.61% <0%> (+0.64%) 36% <0%> (ø) ⬇️
...rc/main/java/com/microsoft/sqlserver/jdbc/DDC.java 25.66% <0%> (+0.66%) 42% <0%> (+3%) ⬆️
...in/java/com/microsoft/sqlserver/jdbc/IOBuffer.java 36.92% <0%> (+0.69%) 0% <0%> (ø) ⬇️
...c/main/java/com/microsoft/sqlserver/jdbc/Util.java 39.9% <0%> (+0.71%) 52% <0%> (+1%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b352610...3e9b6e1. Read the comment docs.

@Suraiya-Hameed Suraiya-Hameed self-requested a review March 27, 2017 20:19
@Suraiya-Hameed
Copy link
Contributor

can you add some comments in the code explaining the changes before merging?

@xiangyushawn
Copy link
Contributor Author

@v-suhame sure

@xiangyushawn xiangyushawn merged commit 71bc492 into microsoft:dev Mar 28, 2017
@xiangyushawn xiangyushawn deleted the TVP-precision-fix branch March 29, 2017 18:39
@lilgreenbird lilgreenbird added this to Closed/Merged PRs in MSSQL JDBC Apr 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
MSSQL JDBC
  
Closed/Merged PRs
Development

Successfully merging this pull request may close these issues.

None yet

3 participants