Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert metadataCaching #377

Merged
merged 1 commit into from
Jul 11, 2017

Conversation

xiangyushawn
Copy link
Contributor

@xiangyushawn xiangyushawn commented Jul 11, 2017

revert merge 369e913:
Merge pull request #345 from Microsoft/metadataCaching

just for your information, the git command I used is:
git revert 369e913e0ba30ddbab658fc32c66ed56a6d53014 -m 1

@codecov-io
Copy link

Codecov Report

Merging #377 into RTW_6.2.0 will increase coverage by 0.14%.
The diff coverage is 77.57%.

Impacted file tree graph

@@               Coverage Diff               @@
##             RTW_6.2.0     #377      +/-   ##
===============================================
+ Coverage        40.27%   40.41%   +0.14%     
+ Complexity        1896     1826      -70     
===============================================
  Files              107      103       -4     
  Lines            24486    23666     -820     
  Branches          4039     3919     -120     
===============================================
- Hits              9862     9565     -297     
+ Misses           12786    12427     -359     
+ Partials          1838     1674     -164
Flag Coverage Δ Complexity Δ
#JDBC41 40.18% <77.57%> (+0.05%) 1814 <38> (-74) ⬇️
#JDBC42 40.36% <77.57%> (+0.17%) 1826 <38> (-64) ⬇️
Impacted Files Coverage Δ Complexity Δ
...om/microsoft/sqlserver/jdbc/SQLServerResource.java 100% <ø> (ø) 4 <0> (ø) ⬇️
.../com/microsoft/sqlserver/jdbc/SQLServerDriver.java 75.3% <100%> (-0.15%) 25 <0> (ø)
...m/microsoft/sqlserver/jdbc/SQLServerStatement.java 59.59% <100%> (+0.22%) 138 <0> (+8) ⬆️
.../microsoft/sqlserver/jdbc/SQLServerDataSource.java 46.53% <100%> (-0.59%) 64 <2> (-2)
...oft/sqlserver/jdbc/SQLServerParameterMetaData.java 25.52% <100%> (ø) 30 <1> (ø) ⬇️
...oft/sqlserver/jdbc/SQLServerPreparedStatement.java 41.06% <68.83%> (-1.33%) 115 <15> (-21)
.../microsoft/sqlserver/jdbc/SQLServerConnection.java 44.74% <78.68%> (-0.51%) 269 <20> (+1)
src/main/java/microsoft/sql/DateTimeOffset.java 37.14% <0%> (-2.86%) 8% <0%> (-2%)
...a/com/microsoft/sqlserver/jdbc/ParameterUtils.java 62.22% <0%> (-2.23%) 19% <0%> (-1%)
...a/com/microsoft/sqlserver/jdbc/PLPInputStream.java 39.75% <0%> (-1.21%) 28% <0%> (-1%)
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6acd67c...90693b1. Read the comment docs.

@AfsanehR-zz AfsanehR-zz self-requested a review July 11, 2017 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
MSSQL JDBC
  
Closed/Merged PRs
Development

Successfully merging this pull request may close these issues.

None yet

5 participants