New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simple javadoc fix for accomodating the newst maven version #385

Merged
merged 1 commit into from Jul 17, 2017

Conversation

Projects
None yet
5 participants
@peterbae
Member

peterbae commented Jul 14, 2017

With the newest maven version, they check for the javadoc syntax more rigorously. Made changes to reflect this new maven behavior.

@msftclas

This comment has been minimized.

msftclas commented Jul 14, 2017

@peterbae,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

@codecov-io

This comment has been minimized.

codecov-io commented Jul 14, 2017

Codecov Report

Merging #385 into dev will increase coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev     #385      +/-   ##
============================================
+ Coverage     40.16%   40.23%   +0.07%     
+ Complexity     1892     1891       -1     
============================================
  Files           107      107              
  Lines         24482    24482              
  Branches       4038     4038              
============================================
+ Hits           9833     9851      +18     
+ Misses        12815    12792      -23     
- Partials       1834     1839       +5
Flag Coverage Δ Complexity Δ
#JDBC41 40.02% <ø> (-0.03%) 1883 <ø> (ø)
#JDBC42 40.17% <ø> (+0.16%) 1889 <ø> (+4) ⬆️
Impacted Files Coverage Δ Complexity Δ
...m/microsoft/sqlserver/jdbc/SQLServerException.java 77.23% <ø> (ø) 29 <0> (ø) ⬇️
...om/microsoft/sqlserver/jdbc/SimpleInputStream.java 47.4% <0%> (-1.49%) 9% <0%> (-1%)
...om/microsoft/sqlserver/jdbc/ReaderInputStream.java 47.19% <0%> (-1.13%) 16% <0%> (-1%)
...om/microsoft/sqlserver/jdbc/SQLServerBulkCopy.java 49.43% <0%> (-0.08%) 211% <0%> (+1%)
...m/microsoft/sqlserver/jdbc/SQLServerResultSet.java 27.36% <0%> (-0.05%) 187% <0%> (-1%)
...in/java/com/microsoft/sqlserver/jdbc/IOBuffer.java 45.54% <0%> (+0.61%) 0% <0%> (ø) ⬇️
...rc/main/java/com/microsoft/sqlserver/jdbc/DDC.java 30.78% <0%> (+0.67%) 58% <0%> (ø) ⬇️
...a/com/microsoft/sqlserver/jdbc/PLPInputStream.java 40.96% <0%> (+1.2%) 29% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3bd68b5...d7b8eef. Read the comment docs.

@peterbae peterbae merged commit f8034a7 into Microsoft:dev Jul 17, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ajlam ajlam removed the PR Under Review label Jul 17, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment