Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update error messages for localization #452

Merged
merged 6 commits into from
Aug 18, 2017

Conversation

xiangyushawn
Copy link
Contributor

No description provided.

@codecov-io
Copy link

Codecov Report

Merging #452 into dev will increase coverage by 0.08%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev     #452      +/-   ##
============================================
+ Coverage     46.24%   46.32%   +0.08%     
- Complexity     2195     2200       +5     
============================================
  Files           108      108              
  Lines         25212    25212              
  Branches       4165     4165              
============================================
+ Hits          11659    11680      +21     
+ Misses        11533    11510      -23     
- Partials       2020     2022       +2
Flag Coverage Δ Complexity Δ
#JDBC41 46.21% <ø> (+0.14%) 2194 <ø> (+9) ⬆️
#JDBC42 46.15% <ø> (-0.02%) 2192 <ø> (-1)
Impacted Files Coverage Δ Complexity Δ
...om/microsoft/sqlserver/jdbc/SQLServerResource.java 100% <ø> (ø) 4 <0> (ø) ⬇️
...n/java/com/microsoft/sqlserver/jdbc/Parameter.java 63.73% <0%> (-0.22%) 62% <0%> (-1%)
...om/microsoft/sqlserver/jdbc/SQLServerBulkCopy.java 52.54% <0%> (-0.07%) 239% <0%> (ø)
...m/microsoft/sqlserver/jdbc/SQLServerResultSet.java 33.06% <0%> (+0.2%) 244% <0%> (+2%) ⬆️
...ncurrentlinkedhashmap/ConcurrentLinkedHashMap.java 42.42% <0%> (+0.21%) 46% <0%> (ø) ⬇️
...in/java/com/microsoft/sqlserver/jdbc/IOBuffer.java 53.92% <0%> (+0.26%) 0% <0%> (ø) ⬇️
...rc/main/java/com/microsoft/sqlserver/jdbc/DDC.java 44.71% <0%> (+0.44%) 105% <0%> (+1%) ⬆️
...om/microsoft/sqlserver/jdbc/SimpleInputStream.java 52.59% <0%> (+1.48%) 12% <0%> (+1%) ⬆️
...om/microsoft/sqlserver/jdbc/ReaderInputStream.java 47.19% <0%> (+5.61%) 16% <0%> (+2%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0f5a5fb...3a9d8da. Read the comment docs.

@codecov-io
Copy link

codecov-io commented Aug 17, 2017

Codecov Report

Merging #452 into dev will increase coverage by 0.13%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev     #452      +/-   ##
============================================
+ Coverage     46.24%   46.38%   +0.13%     
- Complexity     2195     2204       +9     
============================================
  Files           108      108              
  Lines         25212    25212              
  Branches       4165     4165              
============================================
+ Hits          11659    11694      +35     
+ Misses        11533    11493      -40     
- Partials       2020     2025       +5
Flag Coverage Δ Complexity Δ
#JDBC41 46.23% <ø> (+0.15%) 2194 <ø> (+9) ⬆️
#JDBC42 46.19% <ø> (+0.02%) 2198 <ø> (+5) ⬆️
Impacted Files Coverage Δ Complexity Δ
...om/microsoft/sqlserver/jdbc/SQLServerResource.java 100% <ø> (ø) 4 <0> (ø) ⬇️
...n/java/com/microsoft/sqlserver/jdbc/Parameter.java 63.51% <0%> (-0.43%) 62% <0%> (-1%)
...om/microsoft/sqlserver/jdbc/SQLServerBulkCopy.java 52.67% <0%> (+0.06%) 241% <0%> (+2%) ⬆️
...m/microsoft/sqlserver/jdbc/SQLServerResultSet.java 33.26% <0%> (+0.4%) 246% <0%> (+4%) ⬆️
...rc/main/java/com/microsoft/sqlserver/jdbc/DDC.java 44.71% <0%> (+0.44%) 105% <0%> (+1%) ⬆️
...in/java/com/microsoft/sqlserver/jdbc/IOBuffer.java 54.21% <0%> (+0.56%) 0% <0%> (ø) ⬇️
...om/microsoft/sqlserver/jdbc/SimpleInputStream.java 52.59% <0%> (+1.48%) 12% <0%> (+1%) ⬆️
...om/microsoft/sqlserver/jdbc/ReaderInputStream.java 47.19% <0%> (+5.61%) 16% <0%> (+2%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0f5a5fb...29d4e40. Read the comment docs.

@ulvii
Copy link
Contributor

ulvii commented Aug 17, 2017

309: {"R_AKVURLInvalid", "Invalid url specified: {0}." }, to {"R_AKVURLInvalid", "Invalid URL specified: {0}." },
292: Not sure what ack is. Is this acceptable?
391: {"R_invalidStringValue", "SQL_VARIANT does not support string values more than 8000 length."}, to SQL_VARIANT does not support string values of length > 8000 maybe?

@ulvii
Copy link
Contributor

ulvii commented Aug 17, 2017

389: SQL_VARIANT is not supported in versions of SQL Server before 2008 maybe?

@ulvii
Copy link
Contributor

ulvii commented Aug 17, 2017

392: Use of TVPs containing null sql_variant columns is not supported. ?

@ulvii
Copy link
Contributor

ulvii commented Aug 17, 2017

225: can not to cannot

@ulvii
Copy link
Contributor

ulvii commented Aug 17, 2017

263: Please remove the extra space between encryption key and :

@ulvii
Copy link
Contributor

ulvii commented Aug 17, 2017

367: Please remove 2 spaces between must be specified, and if

@ulvii
Copy link
Contributor

ulvii commented Aug 17, 2017

375: Please remove the space after {"R_TVPnotWorkWithSetObjectResultSet"

@xiangyushawn xiangyushawn merged commit e581dcf into microsoft:dev Aug 18, 2017
@lilgreenbird lilgreenbird added this to Closed/Merged PRs in MSSQL JDBC Apr 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
MSSQL JDBC
  
Closed/Merged PRs
Development

Successfully merging this pull request may close these issues.

None yet

4 participants