Replace explicit types with <> (The diamond operator). #468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes duplicated information when instantiating variables, and increases the readability. For example:
```Java
EnumMap<CallableHandles, HandleAssociation> handleMap =
new EnumMap<CallableHandles, HandleAssociation>(CallableHandles.class);
```
becomes
```Java
EnumMap<CallableHandles, HandleAssociation> handleMap =
new EnumMap<>(CallableHandles.class);
```
and
```Java
private static final EnumMap<SSType.Category, EnumSet<JDBCType.Category>> conversionMap =
new EnumMap<SSType.Category, EnumSet<JDBCType.Category>>(SSType.Category.class);
```
becomes
```Java
private static final EnumMap<SSType.Category, EnumSet<JDBCType.Category>> conversionMap =
new EnumMap<>(SSType.Category.class);
```
This reverts commit e277087.
…/mssql-jdbc into JamieMagee-explicit-type-diamond
|
@peterbae, |
Codecov Report
@@ Coverage Diff @@
## dev #468 +/- ##
============================================
+ Coverage 46.16% 46.29% +0.13%
- Complexity 2193 2200 +7
============================================
Files 108 108
Lines 25227 25227
Branches 4172 4172
============================================
+ Hits 11645 11679 +34
+ Misses 11563 11519 -44
- Partials 2019 2029 +10
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
solved conflict in #420