Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary return statements #471

Merged
merged 1 commit into from
Sep 21, 2017

Conversation

JamieMagee
Copy link
Member

return; is unnecessary if it is the last statement in a void method

`return;` is unnecessary if it is the last statement in a `void` method
@codecov-io
Copy link

Codecov Report

Merging #471 into dev will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev     #471      +/-   ##
============================================
+ Coverage     46.26%   46.28%   +0.01%     
- Complexity     2201     2203       +2     
============================================
  Files           108      108              
  Lines         25227    25226       -1     
  Branches       4172     4172              
============================================
+ Hits          11672    11675       +3     
+ Misses        11538    11537       -1     
+ Partials       2017     2014       -3
Flag Coverage Δ Complexity Δ
#JDBC41 46.09% <ø> (+0.02%) 2196 <ø> (+4) ⬆️
#JDBC42 46.12% <ø> (+0.01%) 2195 <ø> (-2) ⬇️
Impacted Files Coverage Δ Complexity Δ
...osoft/sqlserver/jdbc/SQLServerSecurityUtility.java 50.74% <ø> (ø) 10 <0> (ø) ⬇️
...va/com/microsoft/sqlserver/jdbc/StreamTabName.java 85% <ø> (ø) 7 <0> (ø) ⬇️
...rc/main/java/com/microsoft/sqlserver/jdbc/DDC.java 44.81% <ø> (-0.13%) 105 <0> (+1)
...om/microsoft/sqlserver/jdbc/ReaderInputStream.java 44.94% <0%> (-2.25%) 16% <0%> (ø)
...n/java/com/microsoft/sqlserver/jdbc/Parameter.java 62.01% <0%> (-0.65%) 63% <0%> (-1%)
...om/microsoft/sqlserver/jdbc/SQLServerBulkCopy.java 52.58% <0%> (-0.07%) 238% <0%> (-1%)
...m/microsoft/sqlserver/jdbc/SQLServerResultSet.java 33.26% <0%> (+0.04%) 245% <0%> (+1%) ⬆️
...in/java/com/microsoft/sqlserver/jdbc/IOBuffer.java 53.48% <0%> (+0.13%) 0% <0%> (ø) ⬇️
...m/microsoft/sqlserver/jdbc/SQLServerStatement.java 59.36% <0%> (+0.3%) 130% <0%> (+1%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a13577...4badd3c. Read the comment docs.

@codecov-io
Copy link

codecov-io commented Sep 1, 2017

Codecov Report

Merging #471 into dev will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev     #471      +/-   ##
============================================
+ Coverage     46.26%   46.28%   +0.01%     
- Complexity     2201     2203       +2     
============================================
  Files           108      108              
  Lines         25227    25226       -1     
  Branches       4172     4172              
============================================
+ Hits          11672    11675       +3     
+ Misses        11538    11537       -1     
+ Partials       2017     2014       -3
Flag Coverage Δ Complexity Δ
#JDBC41 46.09% <ø> (+0.02%) 2196 <ø> (+4) ⬆️
#JDBC42 46.12% <ø> (+0.01%) 2195 <ø> (-2) ⬇️
Impacted Files Coverage Δ Complexity Δ
...rc/main/java/com/microsoft/sqlserver/jdbc/DDC.java 44.81% <ø> (-0.13%) 105 <0> (+1)
...va/com/microsoft/sqlserver/jdbc/StreamTabName.java 85% <ø> (ø) 7 <0> (ø) ⬇️
...osoft/sqlserver/jdbc/SQLServerSecurityUtility.java 50.74% <ø> (ø) 10 <0> (ø) ⬇️
...om/microsoft/sqlserver/jdbc/ReaderInputStream.java 44.94% <0%> (-2.25%) 16% <0%> (ø)
...n/java/com/microsoft/sqlserver/jdbc/Parameter.java 62.01% <0%> (-0.65%) 63% <0%> (-1%)
...om/microsoft/sqlserver/jdbc/SQLServerBulkCopy.java 52.58% <0%> (-0.07%) 238% <0%> (-1%)
...m/microsoft/sqlserver/jdbc/SQLServerResultSet.java 33.26% <0%> (+0.04%) 245% <0%> (+1%) ⬆️
...in/java/com/microsoft/sqlserver/jdbc/IOBuffer.java 53.48% <0%> (+0.13%) 0% <0%> (ø) ⬇️
...m/microsoft/sqlserver/jdbc/SQLServerStatement.java 59.36% <0%> (+0.3%) 130% <0%> (+1%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a13577...4badd3c. Read the comment docs.

@ajlam ajlam modified the milestone: 6.3.3 Sep 5, 2017
@cheenamalhotra cheenamalhotra merged commit 377f77a into microsoft:dev Sep 21, 2017
@JamieMagee JamieMagee deleted the unnecessary-return branch September 22, 2017 09:18
@lilgreenbird lilgreenbird added this to Closed/Merged PRs in MSSQL JDBC Apr 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
MSSQL JDBC
  
Closed/Merged PRs
Development

Successfully merging this pull request may close these issues.

None yet

5 participants