Blob fix #595
Merged
Blob fix #595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fills the contents of a blob and makes it availible for use after the RS or statement has been closed. Addresses the TDS issue from microsoft#567.
Codecov Report
@@ Coverage Diff @@
## dev #595 +/- ##
============================================
+ Coverage 46.37% 46.57% +0.19%
- Complexity 2216 2228 +12
============================================
Files 109 109
Lines 25411 25431 +20
Branches 4188 4190 +2
============================================
+ Hits 11784 11844 +60
+ Misses 11602 11548 -54
- Partials 2025 2039 +14
Continue to review full report at Codecov.
|
Fix to issue microsoft#611, where calling length() would close the stream.
pull from main
fix for automatic credential discarding
To debug a random mismatch error which can't be reproduced locally.
Kerb cons del
unexpected error message
Retry logic
pull main
Blob stream
pull 6.4.0
removed arraylist to avoid costly traversal. Blobs now fill anytime the resultset moves its cursor.
added tests which specifically test blob streams and behavior after the RS is closed.
No longer fills blobs on every checkClosed() call. Only attempts to fill them in scenarios where the cursor moves or another change of state which causes the RS to lose its active stream.
wasNull() moves the cursor for some reason, need to fill blobs.
testing expected behavior if users release a blob() object
|
Hi all, |
|
This PR will be in 6.5.0-preview, which will be released sometime in March, when ready. |
peterbae
approved these changes
Mar 6, 2018
|
I have a question: I don't see a final release of 6.5. Did all the changes of 6.5 went into version 7.0? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fills the contents of a blob and makes it availible for use after the RS or statement has been closed. Addresses the TDS issue from #567.