Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix JavaDoc warnings and remove obselete HTML tags #786

Merged
merged 2 commits into from Aug 24, 2018

Conversation

@cheenamalhotra
Copy link
Member

commented Aug 24, 2018

No description provided.

@cheenamalhotra cheenamalhotra added this to Under Peer Review in MSSQL JDBC Aug 24, 2018
@cheenamalhotra cheenamalhotra added this to the 7.1.0 milestone Aug 24, 2018
@codecov-io

This comment has been minimized.

Copy link

commented Aug 24, 2018

Codecov Report

Merging #786 into dev will increase coverage by 0.33%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##                dev    #786      +/-   ##
===========================================
+ Coverage     48.16%   48.5%   +0.33%     
- Complexity     2785    2810      +25     
===========================================
  Files           116     116              
  Lines         27858   27858              
  Branches       4639    4639              
===========================================
+ Hits          13418   13512      +94     
+ Misses        12230   12204      -26     
+ Partials       2210    2142      -68
Flag Coverage Δ Complexity Δ
#JDBC42 47.68% <ø> (+0.08%) 2737 <ø> (-2) ⬇️
#JDBC43 48.37% <ø> (+0.31%) 2805 <ø> (+27) ⬆️
Impacted Files Coverage Δ Complexity Δ
...osoft/sqlserver/jdbc/SQLServerSpatialDatatype.java 85.38% <ø> (ø) 290 <0> (ø) ⬇️
...ncurrentlinkedhashmap/ConcurrentLinkedHashMap.java 38.14% <ø> (ø) 42 <0> (ø) ⬇️
...l/googlecode/concurrentlinkedhashmap/Weighers.java 8.33% <ø> (ø) 1 <0> (ø) ⬇️
...om/microsoft/sqlserver/jdbc/ReaderInputStream.java 46.15% <0%> (-3.3%) 16% <0%> (-1%)
...om/microsoft/sqlserver/jdbc/SimpleInputStream.java 51.47% <0%> (-1.48%) 11% <0%> (-1%)
...m/microsoft/sqlserver/jdbc/SQLServerResultSet.java 32.69% <0%> (-0.04%) 256% <0%> (ø)
...rc/main/java/com/microsoft/sqlserver/jdbc/dtv.java 62.37% <0%> (+0.05%) 0% <0%> (ø) ⬇️
...c/main/java/com/microsoft/sqlserver/jdbc/Util.java 60.9% <0%> (+0.21%) 90% <0%> (+2%) ⬆️
...m/microsoft/sqlserver/jdbc/SQLServerStatement.java 60.05% <0%> (+0.28%) 142% <0%> (+6%) ⬆️
.../microsoft/sqlserver/jdbc/SQLServerConnection.java 48.45% <0%> (+0.53%) 349% <0%> (+15%) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f415394...f3610dc. Read the comment docs.

@@ -50,14 +50,14 @@
* concurrency for updates, and a maximum capacity to bound the map by. This
* implementation differs from {@link ConcurrentHashMap} in that it maintains a
* page replacement algorithm that is used to evict an entry when the map has
* exceeded its capacity. Unlike the <tt>Java Collections Framework</tt>, this
* exceeded its capacity. Unlike the <b>Java Collections Framework</b>, this

This comment has been minimized.

Copy link
@ulvii

ulvii Aug 24, 2018

Member

Why is this change necessary?

@ulvii
ulvii approved these changes Aug 24, 2018
@cheenamalhotra cheenamalhotra merged commit 5c20b4e into microsoft:dev Aug 24, 2018
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla All CLA requirements met.
Details
MSSQL JDBC automation moved this from Under Peer Review to Closed/Merged PRs Aug 24, 2018
@cheenamalhotra cheenamalhotra deleted the cheenamalhotra:javadoc-warnings branch Aug 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
MSSQL JDBC
  
Closed/Merged PRs
4 participants
You can’t perform that action at this time.