Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Maven dependencies and library versions + Jacoco Support for VSTS #807

Merged
merged 24 commits into from
Oct 5, 2018

Conversation

cheenamalhotra
Copy link
Member

@cheenamalhotra cheenamalhotra commented Sep 21, 2018

This PR:

  • Adds below dependencies to resolve module access issues with new libraries.

    • com.microsoft.azure:azure-keyvault-webkey - v1.1.1 (Optional)
    • com.microsoft.rest:client-runtime - v1.6.2 (Optional)
  • Updates versions of Maven dependencies:

    • com.microsoft.azure:azure-keyvault - v1.1.1
    • com.microsoft.azure:adal4j - v1.6.2
    • org.junit.platform:junit-platform-console - v1.3.1
    • org.junit.platform:junit-platform-commons - v1.3.1
    • org.junit.platform:junit-platform-engine - v1.3.1
    • org.junit.platform:junit-platform-launcher - v1.3.1
    • org.junit.platform:junit-platform-runner - v1.3.1
    • org.junit.platform:junit-platform-surefire-provider - v1.3.1
    • org.junit.jupiter:junit-jupiter-api - v5.3.1
    • org.junit.jupiter:junit-jupiter-engine - v5.3.1
  • Adds "Enforce verisons" plugin to force using minimum versions of JDK and Maven for building driver to avoid any build issues.

  • Updates Maven plugins to their latest versions

  • Moves Jacoco plugins to both profiles - needed to run VSTS Code Coverage tasks.

@cheenamalhotra cheenamalhotra added this to Under Peer Review in MSSQL JDBC Sep 25, 2018
@cheenamalhotra cheenamalhotra added this to the 7.1.2 milestone Sep 28, 2018
lilgreenbird
lilgreenbird previously approved these changes Oct 1, 2018
@codecov-io
Copy link

codecov-io commented Oct 1, 2018

Codecov Report

Merging #807 into dev will decrease coverage by 0.34%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev     #807      +/-   ##
============================================
- Coverage     48.67%   48.33%   -0.35%     
+ Complexity     2817     2783      -34     
============================================
  Files           116      116              
  Lines         27878    27878              
  Branches       4651     4651              
============================================
- Hits          13571    13474      -97     
- Misses        12173    12185      +12     
- Partials       2134     2219      +85
Flag Coverage Δ Complexity Δ
#JDBC42 47.82% <ø> (-0.08%) 2741 <ø> (-6)
#JDBC43 48.21% <ø> (-0.36%) 2776 <ø> (-31)
Impacted Files Coverage Δ Complexity Δ
...in/java/com/microsoft/sqlserver/jdbc/IOBuffer.java 54.68% <0%> (-1.88%) 0% <0%> (ø)
...m/microsoft/sqlserver/jdbc/SQLServerException.java 77.44% <0%> (-1.51%) 31% <0%> (-2%)
...a/com/microsoft/sqlserver/jdbc/PLPInputStream.java 58.33% <0%> (-1.2%) 33% <0%> (-1%)
...n/java/com/microsoft/sqlserver/jdbc/tdsparser.java 68.1% <0%> (-0.87%) 0% <0%> (ø)
...c/main/java/com/microsoft/sqlserver/jdbc/Util.java 60.99% <0%> (-0.65%) 89% <0%> (-3%)
...m/microsoft/sqlserver/jdbc/SQLServerResultSet.java 32.46% <0%> (-0.58%) 253% <0%> (-6%)
.../microsoft/sqlserver/jdbc/SQLServerConnection.java 47.91% <0%> (-0.54%) 334% <0%> (-15%)
...om/microsoft/sqlserver/jdbc/SQLServerBulkCopy.java 52.16% <0%> (-0.31%) 260% <0%> (-3%)
...m/microsoft/sqlserver/jdbc/SQLServerStatement.java 59.51% <0%> (-0.29%) 135% <0%> (-6%)
...n/java/com/microsoft/sqlserver/jdbc/Parameter.java 63.52% <0%> (-0.21%) 64% <0%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 709342f...bf0fee3. Read the comment docs.

@cheenamalhotra cheenamalhotra merged commit 8c00f0e into microsoft:dev Oct 5, 2018
MSSQL JDBC automation moved this from Under Peer Review to Closed/Merged PRs Oct 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
MSSQL JDBC
  
Closed/Merged PRs
Development

Successfully merging this pull request may close these issues.

None yet

4 participants