Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating list of SQL keywords in DatabaseMetaData #829

Merged
merged 1 commit into from
Oct 24, 2018
Merged

Updating list of SQL keywords in DatabaseMetaData #829

merged 1 commit into from
Oct 24, 2018

Conversation

pazkooda
Copy link
Contributor

Source of keywords taken from TSQL documentation

@msftclas
Copy link

msftclas commented Oct 12, 2018

CLA assistant check
All CLA requirements met.

@codecov-io
Copy link

codecov-io commented Oct 12, 2018

Codecov Report

Merging #829 into dev will decrease coverage by 0.03%.
The diff coverage is 66.66%.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev     #829      +/-   ##
============================================
- Coverage     48.38%   48.35%   -0.04%     
+ Complexity     2789     2786       -3     
============================================
  Files           116      116              
  Lines         27878    27880       +2     
  Branches       4651     4651              
============================================
- Hits          13489    13480       -9     
- Misses        12175    12186      +11     
  Partials       2214     2214
Flag Coverage Δ Complexity Δ
#JDBC42 47.89% <66.66%> (ø) 2744 <1> (+1) ⬆️
#JDBC43 48.2% <66.66%> (+0.05%) 2778 <1> (+2) ⬆️
Impacted Files Coverage Δ Complexity Δ
...soft/sqlserver/jdbc/SQLServerDatabaseMetaData.java 33.49% <66.66%> (+0.15%) 63 <1> (+1) ⬆️
...om/microsoft/sqlserver/jdbc/SimpleInputStream.java 52.94% <0%> (-1.48%) 11% <0%> (-1%)
...m/microsoft/sqlserver/jdbc/SQLServerResultSet.java 32.69% <0%> (-0.35%) 255% <0%> (-4%)
...n/java/com/microsoft/sqlserver/jdbc/Parameter.java 63.52% <0%> (-0.21%) 64% <0%> (ø)
...om/microsoft/sqlserver/jdbc/SQLServerBulkCopy.java 52.46% <0%> (-0.13%) 263% <0%> (-1%)
...in/java/com/microsoft/sqlserver/jdbc/IOBuffer.java 54.58% <0%> (-0.1%) 0% <0%> (ø)
...rc/main/java/com/microsoft/sqlserver/jdbc/dtv.java 62.4% <0%> (+0.05%) 0% <0%> (ø) ⬇️
...rc/main/java/com/microsoft/sqlserver/jdbc/DDC.java 45.73% <0%> (+0.43%) 108% <0%> (+1%) ⬆️
...om/microsoft/sqlserver/jdbc/ReaderInputStream.java 45.05% <0%> (+1.09%) 15% <0%> (ø) ⬇️
...a/com/microsoft/sqlserver/jdbc/PLPInputStream.java 59.52% <0%> (+1.19%) 34% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c50d817...3821502. Read the comment docs.

@cheenamalhotra cheenamalhotra added this to Under Peer Review in MSSQL JDBC Oct 12, 2018
@cheenamalhotra cheenamalhotra added this to the 7.1.2 milestone Oct 18, 2018
@cheenamalhotra cheenamalhotra merged commit 895702a into microsoft:dev Oct 24, 2018
MSSQL JDBC automation moved this from Under Peer Review to Closed/Merged PRs Oct 24, 2018
@pazkooda pazkooda deleted the feature/update-list-of-sql-keywords-in-metadata branch February 11, 2019 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
MSSQL JDBC
  
Closed/Merged PRs
Development

Successfully merging this pull request may close these issues.

None yet

7 participants