Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for OffsetDateTime to be passed as 'type' in ResultSet.getObject() #830

Merged
merged 4 commits into from Dec 22, 2018

Conversation

harawata
Copy link
Contributor

As PreparedStatement.setObject(int, Object) already supports java.time.OffsetDateTime, it may make sense.
This was proposed in #749 (comment) , but no work has been done, it seems.

@msftclas
Copy link

msftclas commented Oct 12, 2018

CLA assistant check
All CLA requirements met.

@codecov-io
Copy link

codecov-io commented Oct 12, 2018

Codecov Report

Merging #830 into dev will increase coverage by 0.29%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##               dev     #830      +/-   ##
===========================================
+ Coverage     48.4%   48.69%   +0.29%     
- Complexity    2790     2819      +29     
===========================================
  Files          116      118       +2     
  Lines        27878    27890      +12     
  Branches      4651     4646       -5     
===========================================
+ Hits         13493    13581      +88     
+ Misses       12173    12120      -53     
+ Partials      2212     2189      -23
Flag Coverage Δ Complexity Δ
#JDBC42 48.2% <100%> (+0.24%) 2776 <1> (+28) ⬆️
#JDBC43 48.65% <100%> (+0.38%) 2817 <1> (+37) ⬆️
Impacted Files Coverage Δ Complexity Δ
...m/microsoft/sqlserver/jdbc/SQLServerResultSet.java 32.92% <100%> (-0.2%) 259 <0> (-1)
src/main/java/microsoft/sql/DateTimeOffset.java 44.73% <100%> (+2.27%) 12 <1> (+1) ⬆️
...om/microsoft/sqlserver/jdbc/SQLServerMetaData.java 21.81% <0%> (-2.19%) 0% <0%> (ø)
...m/microsoft/sqlserver/jdbc/SQLServerException.java 75.93% <0%> (-1.51%) 30% <0%> (-1%)
...om/microsoft/sqlserver/jdbc/SimpleInputStream.java 52.94% <0%> (-1.48%) 11% <0%> (-1%)
...rc/main/java/com/microsoft/sqlserver/jdbc/DDC.java 44.68% <0%> (-0.61%) 108% <0%> (+1%)
...om/microsoft/sqlserver/jdbc/SQLServerBulkCopy.java 52.52% <0%> (-0.18%) 265% <0%> (+1%)
...oft/sqlserver/jdbc/SQLServerParameterMetaData.java 24.56% <0%> (ø) 31% <0%> (ø) ⬇️
...va/com/microsoft/sqlserver/jdbc/SQLServerClob.java 35.58% <0%> (ø) 12% <0%> (ø) ⬇️
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c50d817...c28421d. Read the comment docs.

@lilgreenbird lilgreenbird merged commit 33bbc84 into microsoft:dev Dec 22, 2018
MSSQL JDBC automation moved this from Under Investigation to Closed/Merged PRs Dec 22, 2018
@harawata harawata deleted the getobject-with-offsetdatetime branch December 28, 2018 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
MSSQL JDBC
  
Closed/Merged PRs
Development

Successfully merging this pull request may close these issues.

None yet

7 participants