Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address TODOs in tests #873

Merged
merged 6 commits into from
Nov 28, 2018
Merged

Address TODOs in tests #873

merged 6 commits into from
Nov 28, 2018

Conversation

lilgreenbird
Copy link
Member

@lilgreenbird lilgreenbird commented Nov 1, 2018

removed/addressed/created backlog on TODOs

@codecov-io
Copy link

codecov-io commented Nov 1, 2018

Codecov Report

Merging #873 into dev will decrease coverage by 0.29%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##                dev     #873     +/-   ##
===========================================
- Coverage     48.98%   48.68%   -0.3%     
+ Complexity     2821     2796     -25     
===========================================
  Files           116      116             
  Lines         27877    27877             
  Branches       4650     4650             
===========================================
- Hits          13655    13573     -82     
+ Misses        12104    12098      -6     
- Partials       2118     2206     +88
Flag Coverage Δ Complexity Δ
#JDBC42 48.26% <ø> (+0.07%) 2757 <ø> (+7) ⬆️
#JDBC43 48.56% <ø> (-0.36%) 2787 <ø> (-29)
Impacted Files Coverage Δ Complexity Δ
...om/microsoft/sqlserver/jdbc/ReaderInputStream.java 40.65% <0%> (-4.4%) 13% <0%> (-2%)
...in/java/com/microsoft/sqlserver/jdbc/IOBuffer.java 56.2% <0%> (-2.04%) 0% <0%> (ø)
...m/microsoft/sqlserver/jdbc/SQLServerException.java 77.44% <0%> (-1.51%) 31% <0%> (-2%)
...c/main/java/com/microsoft/sqlserver/jdbc/Util.java 60.99% <0%> (-1.08%) 89% <0%> (-4%)
...n/java/com/microsoft/sqlserver/jdbc/tdsparser.java 68.1% <0%> (-0.87%) 0% <0%> (ø)
.../microsoft/sqlserver/jdbc/SQLServerConnection.java 48.09% <0%> (-0.54%) 335% <0%> (-15%)
...m/microsoft/sqlserver/jdbc/SQLServerStatement.java 59.57% <0%> (-0.29%) 135% <0%> (-6%)
...om/microsoft/sqlserver/jdbc/SQLServerBulkCopy.java 52.85% <0%> (+0.12%) 264% <0%> (+1%) ⬆️
...m/microsoft/sqlserver/jdbc/SQLServerResultSet.java 32.77% <0%> (+0.3%) 256% <0%> (+3%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d01e90a...1e270f5. Read the comment docs.

@cheenamalhotra cheenamalhotra added this to the 7.1.3 milestone Nov 20, 2018
@cheenamalhotra cheenamalhotra added this to Under Peer Review in MSSQL JDBC Nov 21, 2018
@lilgreenbird lilgreenbird merged commit 195ea92 into microsoft:dev Nov 28, 2018
MSSQL JDBC automation moved this from Under Peer Review to Closed/Merged PRs Nov 28, 2018
ulvii pushed a commit that referenced this pull request Nov 30, 2018
* address TODOs

* rename var

* rename var

* comments only

* review udpates

* more review updates
ulvii added a commit that referenced this pull request Nov 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
MSSQL JDBC
  
Closed/Merged PRs
Development

Successfully merging this pull request may close these issues.

None yet

5 participants