Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix | Removed populating Lobs when calling wasNull() #875

Merged
merged 1 commit into from
Nov 27, 2018

Conversation

rene-ye
Copy link
Member

@rene-ye rene-ye commented Nov 6, 2018

wasNull() does not actually move the cursor, and it's unnecessary to populate the active lob objects when it's called. Addresses #867.

@codecov-io
Copy link

Codecov Report

Merging #875 into dev will decrease coverage by 0.29%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##                dev     #875     +/-   ##
===========================================
- Coverage     48.98%   48.68%   -0.3%     
+ Complexity     2821     2795     -26     
===========================================
  Files           116      116             
  Lines         27877    27876      -1     
  Branches       4650     4650             
===========================================
- Hits          13655    13571     -84     
+ Misses        12104    12098      -6     
- Partials       2118     2207     +89
Flag Coverage Δ Complexity Δ
#JDBC42 48.2% <ø> (+0.02%) 2753 <ø> (+3) ⬆️
#JDBC43 48.52% <ø> (-0.4%) 2790 <ø> (-26)
Impacted Files Coverage Δ Complexity Δ
...m/microsoft/sqlserver/jdbc/SQLServerResultSet.java 32.66% <ø> (+0.2%) 255 <0> (+2) ⬆️
...in/java/com/microsoft/sqlserver/jdbc/IOBuffer.java 56.2% <0%> (-2.04%) 0% <0%> (ø)
...m/microsoft/sqlserver/jdbc/SQLServerException.java 77.44% <0%> (-1.51%) 31% <0%> (-2%)
...n/java/com/microsoft/sqlserver/jdbc/tdsparser.java 68.1% <0%> (-0.87%) 0% <0%> (ø)
...c/main/java/com/microsoft/sqlserver/jdbc/Util.java 61.42% <0%> (-0.65%) 90% <0%> (-3%)
...ncurrentlinkedhashmap/ConcurrentLinkedHashMap.java 38.14% <0%> (-0.65%) 42% <0%> (-1%)
.../microsoft/sqlserver/jdbc/SQLServerConnection.java 48.09% <0%> (-0.54%) 335% <0%> (-15%)
...m/microsoft/sqlserver/jdbc/SQLServerStatement.java 59.57% <0%> (-0.29%) 135% <0%> (-6%)
...rc/main/java/com/microsoft/sqlserver/jdbc/dtv.java 62.45% <0%> (-0.12%) 0% <0%> (ø)
...rc/main/java/com/microsoft/sqlserver/jdbc/DDC.java 45.73% <0%> (ø) 107% <0%> (-1%) ⬇️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d01e90a...01539e1. Read the comment docs.

@cheenamalhotra cheenamalhotra added this to the 7.1.3 milestone Nov 20, 2018
@cheenamalhotra cheenamalhotra added this to Under Peer Review in MSSQL JDBC Nov 21, 2018
@rene-ye rene-ye merged commit bee1dbe into microsoft:dev Nov 27, 2018
MSSQL JDBC automation moved this from Under Peer Review to Closed/Merged PRs Nov 27, 2018
@rene-ye rene-ye deleted the wasNullBlobs branch October 10, 2019 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
MSSQL JDBC
  
Closed/Merged PRs
Development

Successfully merging this pull request may close these issues.

None yet

5 participants